Thunderbird 52.0.1 version identifier is incorrect - release-thunderbird-comm-esr52.py.template#l45 is missing 'mail/config/version_display.txt'

RESOLVED FIXED

Status

Thunderbird
Build Config
--
blocker
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: wsmwk, Assigned: Fallen)

Tracking

52 Branch

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 months ago
rail writes 

https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/release-thunderbird-comm-esr52.py.template#l45 

is missing 'mail/config/version_display.txt', like in https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/release-thunderbird-comm-beta.py.template#l55.

Once it's fixed, we need to merge the changes to production ... and we need another build after we fix the configs

I can review
Created attachment 8858090 [details] [diff] [review]
Bug1356325.patch

Rail, is this what you thought?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8858090 - Flags: review?(rail)
(Assignee)

Comment 2

6 months ago
Created attachment 8858091 [details] [diff] [review]
Fix - v1

I'm not sure if we need to use nextAppVersion or add nextVersion and use that. I compared with what fennec does and there it seems beta uses nextVersion and release uses nextAppVersion.
Assignee: richard.marti → philipp
Attachment #8858091 - Flags: review?(rail)
Attachment #8858091 - Flags: review?(rail) → review+
Attachment #8858090 - Attachment is obsolete: true
Attachment #8858090 - Flags: review?(rail)

Comment 3

6 months ago
Just a note that when testing release-localtest the correct build ID was shown in troubleshooting information. I tested at least 3 times with various versions
(Assignee)

Comment 4

6 months ago
https://hg.mozilla.org/build/buildbot-configs/rev/65b56e3c86363499b393fdc7a06b7943651b2ebf
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
In production: https://hg.mozilla.org/build/buildbot-configs/rev/65b56e3c8636
You need to log in before you can comment on or make changes to this bug.