1356325 - Thunderbird 52.0.1 version identifier is incorrect - release-thunderbird-comm-esr52.py.template#l45 is missing 'mail/config/version_display.txt'

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Wayne Mery (:wsmwk)]

rail writes 

https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/release-thunderbird-comm-esr52.py.template#l45 

is missing 'mail/config/version_display.txt', like in https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/release-thunderbird-comm-beta.py.template#l55.

Once it's fixed, we need to merge the changes to production ... and we need another build after we fix the configs

I can review

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug1356325.patch

Rail, is this what you thought?

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

I'm not sure if we need to use nextAppVersion or add nextVersion and use that. I compared with what fennec does and there it seems beta uses nextVersion and release uses nextAppVersion.

Comment 3

[Joe Sabash [:JoeS1]]

Just a note that when testing release-localtest the correct build ID was shown in troubleshooting information. I tested at least 3 times with various versions

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://hg.mozilla.org/build/buildbot-configs/rev/65b56e3c86363499b393fdc7a06b7943651b2ebf

Comment 5

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/65b56e3c8636