1356375 - Topsite cell count is not updated after deleting only Topsite icon left

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[No-Jun Park [:njpark]]

Tests in TopsitesTest.swift is disabled, because test was crashing with view inconsistency.  What happens is that when all of the topsite cells are that the count of visible cells decrease as the cells are deleted, but when the last cell is deleted, the count remains 1, yet the cell's isVisibleInViewHierachy() value is set to false. Hence, below code will hit break at the last iteration:

var topSiteCell = tester().waitForView(withAccessibilityIdentifier: "TopSitesCell") as! ASHorizontalScrollCell
        var collection = topSiteCell.collectionView
        
        while collection.visibleCells.count > 0 {
            let firstCell = collection.visibleCells.first!
            if firstCell.isVisibleInViewHierarchy() == false {
                break
            } else {
                // Deletes the cell by long press -> select 'Remove' menu
                deleteSuggestedTopsite(firstCell.accessibilityLabel!)
            }
        }

The workaround is that when the view is changed to something else, like Bookmarks, and return to Topsites view, the number will be updated.  But since it had no problem decrementing the visible cell's count except in the case when there was only one cell left, I believe this is a bug that should be fixed.

Farhan, is this something that can be fixed in short term?  if not, then I'll mark the tests and put workaround to it.

Comment 1

[Farhan Patel [:farhan]]

There's been some changes to Topsites so these tests will need to be completely rewritten.

Comment 2

[Farhan Patel [:farhan]]

Is this still valid? If not could you close this :)

Comment 3

[No-Jun Park [:njpark]]

wait, yeah this change is already made a while ago. closing it.