Closed Bug 1356376 Opened 2 years ago Closed 2 years ago

Intermittent xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_i18n.js | application crashed [@ mozilla::ipc::MessageChannel::Close()]

Categories

(WebExtensions :: General, defect, critical)

defect
Not set
critical

Tracking

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 fixed, firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: kmag)

References

Details

(Keywords: crash, intermittent-failure, Whiteboard: [stockwell fixed:other])

Crash Data

Attachments

(1 file)

This is still happening.
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Except for a very few earlier failures, this started on July 28, very soon after the test was updated by bug 1357902.

:kmag - Please have a look at this frequent intermittent test failure.
Blocks: 1357902
Flags: needinfo?(kmaglione+bmo)
My best guess at this point is that this is just a shutdown race, and we wind up closing the parent side of the PBackground protocol before the child finishes shutting down. That's what the logs seem to suggest, anyway.

We might need to add some sort of shutdown blocker to wait for any content processes to finish shutting down before we let xpcshell exit.
Flags: needinfo?(kmaglione+bmo)
:kmag, this is still a pretty frequent problem- is there work that you or others on the webext team are doing to resolve this in the short term?
Flags: needinfo?(kmaglione+bmo)
Whiteboard: [stockwell needswork]
Yes, I'm planning to work on it today. I didn't have time to get to it before the weekend, and was away on Monday.
Flags: needinfo?(kmaglione+bmo)
Comment on attachment 8900923 [details]
Bug 1356376: Wait for message manager to disconnect after closing content page.

https://reviewboard.mozilla.org/r/172362/#review177768
Attachment #8900923 - Flags: review?(aswan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d10651944d76db8519d7a317f576377bc83f6d8e
Bug 1356376: Wait for message manager to disconnect after closing content page. r=aswan
https://hg.mozilla.org/mozilla-central/rev/d10651944d76
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee: nobody → kmaglione+bmo
Whiteboard: [stockwell needswork] → [stockwell fixed:other]
Please request Beta approval on this when you get a chance.
Flags: needinfo?(kmaglione+bmo)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #18)
> Please request Beta approval on this when you get a chance.

This is a test-only change. If it's causing problems on beta, feel free to uplift.
Flags: needinfo?(kmaglione+bmo)
OrangeFactor still shows failures for this bug: https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356376
Should this bug be reopened or a new one filed?
Flags: needinfo?(kmaglione+bmo)
bummer this didn't fix the problem.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [stockwell fixed:other] → [stockwell needswork]
I'll take another look. If I can't find an obvious solution, I'll just skip this test on Windows e10s. Coverage on other platforms should be sufficient.
Flags: needinfo?(kmaglione+bmo)
https://hg.mozilla.org/integration/mozilla-inbound/rev/8757cd6f0b2ac4bc9f7424a90d8780969353b0f5
Bug 1356376: Skip test_ext_i18n.js on Windows debug for frequent intermittent failures. r=me,test-only
https://hg.mozilla.org/mozilla-central/rev/8757cd6f0b2a
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Whiteboard: [stockwell needswork] → [stockwell fixed:other]
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(kmaglione+bmo) → qe-verify-
See Also: → 1408609
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.