Closed
Bug 1356376
Opened 7 years ago
Closed 7 years ago
Intermittent xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_i18n.js | application crashed [@ mozilla::ipc::MessageChannel::Close()]
Categories
(WebExtensions :: General, defect)
WebExtensions
General
Tracking
(firefox-esr52 unaffected, firefox55 unaffected, firefox56 fixed, firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | fixed |
firefox57 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: kmag)
References
Details
(Keywords: crash, intermittent-failure, Whiteboard: [stockwell fixed:other])
Crash Data
Attachments
(1 file)
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=91154394&repo=autoland https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-win64-debug/1492051508/autoland_win8_64-debug_test-xpcshell-bm109-tests1-windows-build135.txt.gz
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: bulk-close-intermittents
Resolution: --- → INCOMPLETE
Comment hidden (Intermittent Failures Robot) |
Comment 2•7 years ago
|
||
This is still happening.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 7•7 years ago
|
||
Except for a very few earlier failures, this started on July 28, very soon after the test was updated by bug 1357902. :kmag - Please have a look at this frequent intermittent test failure.
Blocks: 1357902
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Comment 8•7 years ago
|
||
My best guess at this point is that this is just a shutdown race, and we wind up closing the parent side of the PBackground protocol before the child finishes shutting down. That's what the logs seem to suggest, anyway. We might need to add some sort of shutdown blocker to wait for any content processes to finish shutting down before we let xpcshell exit.
Flags: needinfo?(kmaglione+bmo)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 11•7 years ago
|
||
:kmag, this is still a pretty frequent problem- is there work that you or others on the webext team are doing to resolve this in the short term?
Flags: needinfo?(kmaglione+bmo)
Whiteboard: [stockwell needswork]
Assignee | ||
Comment 12•7 years ago
|
||
Yes, I'm planning to work on it today. I didn't have time to get to it before the weekend, and was away on Monday.
Flags: needinfo?(kmaglione+bmo)
Comment hidden (mozreview-request) |
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8900923 [details] Bug 1356376: Wait for message manager to disconnect after closing content page. https://reviewboard.mozilla.org/r/172362/#review177768
Attachment #8900923 -
Flags: review?(aswan) → review+
Assignee | ||
Comment 15•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d10651944d76db8519d7a317f576377bc83f6d8e Bug 1356376: Wait for message manager to disconnect after closing content page. r=aswan
Comment hidden (Intermittent Failures Robot) |
Comment 17•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d10651944d76
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•7 years ago
|
Assignee: nobody → kmaglione+bmo
Whiteboard: [stockwell needswork] → [stockwell fixed:other]
Comment 18•7 years ago
|
||
Please request Beta approval on this when you get a chance.
status-firefox56:
--- → affected
Flags: needinfo?(kmaglione+bmo)
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Assignee | ||
Comment 19•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #18) > Please request Beta approval on this when you get a chance. This is a test-only change. If it's causing problems on beta, feel free to uplift.
Flags: needinfo?(kmaglione+bmo)
Comment 20•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/68bdcc4270e1
Comment 21•7 years ago
|
||
OrangeFactor still shows failures for this bug: https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356376 Should this bug be reopened or a new one filed?
Flags: needinfo?(kmaglione+bmo)
Comment 22•7 years ago
|
||
bummer this didn't fix the problem.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [stockwell fixed:other] → [stockwell needswork]
Assignee | ||
Comment 23•7 years ago
|
||
I'll take another look. If I can't find an obvious solution, I'll just skip this test on Windows e10s. Coverage on other platforms should be sufficient.
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Comment 24•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8757cd6f0b2ac4bc9f7424a90d8780969353b0f5 Bug 1356376: Skip test_ext_i18n.js on Windows debug for frequent intermittent failures. r=me,test-only
Comment 25•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8757cd6f0b2a
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Whiteboard: [stockwell needswork] → [stockwell fixed:other]
Comment 26•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/6f0cfcff6de6
Comment hidden (Intermittent Failures Robot) |
Comment 28•6 years ago
|
||
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag. Thanks!
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(kmaglione+bmo) → qe-verify-
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•