1356458 - Drive Stylo static analysis hazard threshold to zero

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Bobby Holley (:bholley)]

Steve landed the analysis in bug 1294915 (\o/) but there are still 7 hazards, and actually 9 as of a few minutes ago. We have a threshold value to prevent us from adding more, but we should drive that number to zero. We have some dependent bugs about this already, which I've assigned to Manish for easy fixes or triaging.

Comment 1

[Chris Peterson [:cpeterson]]

We should try to fix all of Stylo's static analysis hazards before we enable Stylo by default on Nightly.

Comment 2

[Manish Goregaokar [:manishearth]]

I think I've fixed all of the actual bugs in the code (and updated the whitelist as much as I can.)

The remaining ones seem to be cases  where the current analysis is inadequate. Steve, can you take it from here?

Comment 3

[Bobby Holley (:bholley)]

This is work that needs to happen on the analysis, which Steve committed to doing this month. Switching categories.

Comment 4

[Steve Fink [:sfink] [:s:]]

The threshold is now zero.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Steve Fink [:sfink] [:s:] from comment #4)
> The threshold is now zero.

Steve, can we resolve this Stylo hazard bug as fixed? Do you know of any remaining work or cleanup?

Comment 6

[Steve Fink [:sfink] [:s:]]

Yeah, this does seem to be fixed.

Let's see, I had some ideas for how to make things a little nicer -- eg, having an easy way to mark safe outparams in the source. But that sort of thing seems like it should be a separate bug anyway.