1356461 - [e10s] Buttons on homepage don't work after moving it to new window

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[684sigma]

User Agent 	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

I have a problem with Firefox Beta 52. It also happens in Beta 53, Nightly 55. Doesn't happen in ESR 45.
Buttons on homepage don't work after moving it to new window. Here's how to reproduce the bug:

1. Open new tab, navigate to about:home in that tab
2. Move the tab to a new window
3. Click on "Options" button on the page

Result: Options do not open.
Expected: Options should open.

Comment 1

[Loic]

The bug exists probably since the implementation of e10s, the old FF40 is affected too with e10s turned on.

Gijs, are you aware of this code area?

Comment 2

[:Gijs (he/him)]

I expect this is because we either don't re-fire pageshow triggering an AboutHomeLoad custom event, or we fire it before the content script has loaded in the new browser into which we're swapping the docshell.

I guess we could workaround by making the abouthome code in tab-content.js check if isAboutHome() is already true and if the document is already loaded. I don't know if that's a sensible workaround, or if we need to do something more fundamental about when frame scripts load or how we swap docshells, and if there's other in-content logic we'd need to do something like that for (or if we can change the about:-related logic to use some other mechanism that doesn't depend on this as heavily). Felipe, do you know? Seems like you reviewed Bill's original work here.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Answering this old question: I don't know either if we need to do something more fundamental here. I think the moving-tab-to-a-new-window has always been a fragile procedure. We could try to investigate if everything is set up properly with e10s these days, but I haven't heard of other bugs related to that recently, so I believe it's at least in good shape..

So a simple workaround would be my go-to solution if it fixes the problem..

Comment 5

[:Gijs (he/him)]

I think we're removing about:home soon in favour of AS, so I don't think we need to do anything here.

Mardak, do we have a bug tracking removal this can depend on?

Comment 6

[Ed Lee :Mardak]

Old about:home was removed in bug 1409054.
https://hg.mozilla.org/mozilla-central/rev/81367b23ee5f

Comment 7

[Cristian Fogel [:cfogel]]

Managed to reproduce using Win 10x64, Win8.1x64 with the Firefox 53.0 build.

Have checked with 62.0b6 on Win 10x64, Ubuntu 16.0.4LTS, and 62.0b7 on MacOS 10.13.4.
Can confirm the issue is fixed.