1356466 - Intermittent dom/workers/test/serviceworkers/test_devtools_track_serviceworker_time.html | We shouldn't get sw when we are notified for frist time updating - got 3, expected -1

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=91519662&repo=autoland

https://queue.taskcluster.net/v1/task/S_1-wyHKS0yd-ku2ZDIA3Q/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Intermittent Failures Robot]

25 failures in 894 pushes (0.028 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 10
* mozilla-inbound: 8
* mozilla-central: 5
* try: 2

Platform breakdown:
* linux64: 16
* linux32: 7
* linux32-nightly: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356466&startday=2017-04-10&endday=2017-04-16&tree=all

Comment 2

[Geoff Brown [:gbrown] (pto Apr 11-18)]

This is a new test, failing intermittently on linux since added in bug 1251238.

:tt - Please try to make this test more reliable.

Comment 3

[Intermittent Failures Robot]

15 failures in 100 pushes (0.15 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 8
* mozilla-inbound: 3
* mozilla-central: 2
* graphics: 2

Platform breakdown:
* linux64: 11
* linux32: 3
* linux64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356466&startday=2017-04-17&endday=2017-04-17&tree=all

Comment 4

[Tom Tung [:tt, :ttung]]

Start to work on this.

Comment 5

[Tom Tung [:tt, :ttung]]

Attachment: [Final] Bug 1356466: Make checking function resolve late enough to prevent from unregistering too early.

Hi Ben,

I think I find out the reason why causing this intermittent. The reason is I resolve promise too early[1] to make checks[2] finish. Once the promise is resolved, the test will unregister the service worker which terminates the service worker and hits the assertion. The solution is to ensure we've done all the checks and then resolve the promise. After applying this patch, the test won't fail by running 200 times rr of opt and debug builds in my local linux machine. 

Could you help me to review this patch? Thanks!

[1] http://searchfox.org/mozilla-central/source/dom/workers/test/serviceworkers/test_devtools_track_serviceworker_time.html#167
[2] http://searchfox.org/mozilla-central/source/dom/workers/test/serviceworkers/test_devtools_track_serviceworker_time.html#162

Comment 6

[Tom Tung [:tt, :ttung]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=76b6c1cd6cc2447e4bf47014bb2cd2a9179e9ea2

Comment 7

[Tom Tung [:tt, :ttung]]

Oops, I forgot to ni...
ni :bkelly for comment 5

Comment 8

[Intermittent Failures Robot]

29 failures in 186 pushes (0.156 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 11
* mozilla-inbound: 10
* try: 3
* graphics: 3
* mozilla-central: 2

Platform breakdown:
* linux64: 26
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356466&startday=2017-04-19&endday=2017-04-19&tree=all

Comment 9

[Tom Tung [:tt, :ttung]]

Thanks for the review!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2ea72d6ed2c
Make checking function resolve late enough to prevent from unregistering too early. r=bkelly

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

Thanks for getting a patch put together, I will check on in this in a couple days!

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e2ea72d6ed2c

Comment 13

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Looking good now. Thanks Tom!

Comment 14

[Intermittent Failures Robot]

71 failures in 817 pushes (0.087 failures/push) were associated with this bug in the last 7 days. 

This is the #6 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 31
* mozilla-inbound: 16
* mozilla-central: 12
* graphics: 7
* try: 5

Platform breakdown:
* linux64: 61
* linux32: 9
* linux64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356466&startday=2017-04-17&endday=2017-04-23&tree=all