1356476 - Web platform tests (tc-W(Wd)) are not using their tooltool cache as expected

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mike Hommey [:glandium]]

From the logs:

[task 2017-04-14T01:12:30.590480Z] 01:12:30     INFO -  WARNING - Impossible to add file geckodriver-v0.15.0-linux64.tar.gz to cache folder /builds/tooltool_cache
[task 2017-04-14T01:12:30.590842Z] 01:12:30    ERROR -  Traceback (most recent call last):
[task 2017-04-14T01:12:30.591403Z] 01:12:30     INFO -    File "/home/worker/checkouts/gecko/taskcluster/docker/recipes/tooltool.py", line 677, in fetch_files
[task 2017-04-14T01:12:30.591763Z] 01:12:30     INFO -      os.makedirs(cache_folder, 0700)
[task 2017-04-14T01:12:30.592148Z] 01:12:30     INFO -    File "/usr/lib/python2.7/os.py", line 150, in makedirs
[task 2017-04-14T01:12:30.592544Z] 01:12:30     INFO -      makedirs(head, mode)
[task 2017-04-14T01:12:30.592894Z] 01:12:30     INFO -    File "/usr/lib/python2.7/os.py", line 157, in makedirs
[task 2017-04-14T01:12:30.593289Z] 01:12:30     INFO -      mkdir(name, mode)
[task 2017-04-14T01:12:30.593768Z] 01:12:30     INFO -  OSError: [Errno 13] Permission denied: '/builds'
[task 2017-04-14T01:12:30.618397Z] 01:12:30     INFO - Return code: 0
[task 2017-04-14T01:12:30.618767Z] 01:12:30     INFO - Running command: ['tar', 'xf', u'/home/worker/workspace/build/geckodriver-v0.15.0-linux64.tar.gz'] in /home/worker/workspace/build

Bug 1355731 changes that to use a mach command that wraps tooltool and that command fails when the cache is not properly used, turning the above ignore error into a hard error.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1356476 - Don't enable tooltool cache on web platform tests.

Those jobs, running on taskcluster, don't have a persistent cache
anyways, so we might as well not pretend setting a tooltool cache does
anything, especially considering the configured directory is not
writeable anyways.

Review commit: https://reviewboard.mozilla.org/r/130162/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130162/

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8858210 [details]
Bug 1356476 - Don't enable tooltool cache on web platform tests.

https://reviewboard.mozilla.org/r/130162/#review133000

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/732e044f9ce4
Don't enable tooltool cache on web platform tests. r=mshal

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/732e044f9ce4