1356502 - Let MediaDatra::GetEndTime() return a TimeUnit

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1356502. P1 - let MediaDatra::GetEndTime() return a TimeUnit instead of ambiguous int64_t.

Review commit: https://reviewboard.mozilla.org/r/130998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130998/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1356502. P2 - let VideoData::UpdateTimestamp() take a TimeUnit instead of ambiguous int64_t.

Review commit: https://reviewboard.mozilla.org/r/131000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131000/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8858988 [details]
Bug 1356502. P1 - let MediaDatra::GetEndTime() return a TimeUnit instead of ambiguous int64_t.

https://reviewboard.mozilla.org/r/130998/#review133576

::: commit-message-a374c:1
(Diff revision 1)
> +Bug 1356502. P1 - let MediaDatra::GetEndTime() return a TimeUnit.

As warned recently, I'd really like to see commit descriptions that tell a bit more than just what's changed.
Now, you have already checked-in a few of these TimeUnit changes, so it would be weird to start adding blurbs about TimeUnit this late!

So how about just adding "instead of ambiguous int64_t" to the one-liner? Just that would be a good justification for this series of patches.

(And same with the other commit, thanks.)

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8858989 [details]
Bug 1356502. P2 - let VideoData::UpdateTimestamp() take a TimeUnit instead of ambiguous int64_t.

https://reviewboard.mozilla.org/r/131000/#review133580

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks! I will fix the commit messages.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8858988 [details]
Bug 1356502. P1 - let MediaDatra::GetEndTime() return a TimeUnit instead of ambiguous int64_t.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130998/diff/1-2/

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8858989 [details]
Bug 1356502. P2 - let VideoData::UpdateTimestamp() take a TimeUnit instead of ambiguous int64_t.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131000/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81075cec11c8
P1 - let MediaDatra::GetEndTime() return a TimeUnit instead of ambiguous int64_t. r=gerald
https://hg.mozilla.org/integration/autoland/rev/aa65ad8d0690
P2 - let VideoData::UpdateTimestamp() take a TimeUnit instead of ambiguous int64_t. r=gerald

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81075cec11c8
https://hg.mozilla.org/mozilla-central/rev/aa65ad8d0690