Buttons on the right-side of the preferences should be mainly uniform in width

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Preferences
VERIFIED FIXED
4 months ago
4 months ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

(Blocks: 1 bug)

55 Branch
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Created attachment 8858236 [details]
Screenshot of spec

As the latest spec shows, the buttons that are along the right side of the preferences should have a min-width of about 150px. Some buttons, such as the "Change master password...", button will have to be wider but all buttons can have a min-width of 150px. This will help the preferences look more aligned.

See spec: https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/217167680
(Assignee)

Updated

4 months ago
Blocks: 1335907
No longer depends on: 1335907
(Assignee)

Updated

4 months ago
Blocks: 1324168
No longer blocks: 1335907
I measured the spec again and it's closer to 145px so I went with that.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Attachment #8858390 - Flags: review?(florian) → review?(mconley)

Comment 4

4 months ago
mozreview-review
Comment on attachment 8858390 [details]
Bug 1356508 - Buttons on the right-side of the preferences UI should be mainly uniform in width.

https://reviewboard.mozilla.org/r/130332/#review133934

Sorry for the delay, thanks! Note that I didn't test this patch manually.
Attachment #8858390 - Flags: review?(mconley) → review+

Comment 5

4 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/369e9c270e27
Buttons on the right-side of the preferences UI should be mainly uniform in width. r=mconley

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/369e9c270e27
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(Assignee)

Updated

4 months ago
Depends on: 1357827
Screenshots of the change: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=3f9f6d6086b2d247831d1d03d530095bebd5a6b2&newProject=mozilla-central&newRev=2458112439037abae9e72fc0612b75fe7a82344d&filter=_preferences_

Comment 8

4 months ago
I have reproduced this bug with Firefox nightly 55.0a1 (2017-04-14) on Windows 10, 64 Bit.

The Bug's fix is now verified on latest nightly 55.0a1 .

Build ID 	20170502030211
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170502]
(Assignee)

Updated

4 months ago
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.