1356520 - Set TOOLTOOL_CACHE to /home/worker/tooltool-cache where it makes sense in mozharness

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1356520 - Set TOOLTOOL_CACHE to /home/worker/tooltool-cache where it makes sense in mozharness.

The current setup is confusing, and, I guess, an inheritage from when
the same mozharness configs were used for buildbot and taskcluster jobs.

When mozharness calls tooltool_wrapper.sh, it doesn't set the
TOOLTOOL_CACHE environment variable from its configuration, like it does
for other commands. Instead, it passes the -c flag with the path from
its configuration. Then tooltool_wrapper.sh proceeds with ignoring the
-c flag and using TOOLTOOL_CACHE from the original environment,
inherited from the taskcluster setup script.

The upcoming new wrapper for tooltool in bug 1355731 doesn't keep this
confusing behavior, and respects the cache directory it's given on the
command line.

Now that most jobs run on taskcluster, and few use the same mozharness
config between buildbot and taskcluster, we can now go ahead and change
the TOOLTOOL_CACHE path in the mozharness config to match reality.

The list of files modified was generated from looking at
MOZHARNESS_CONFIG values in the full-task-graph.json file coming from
the Gecko decision task.

Review commit: https://reviewboard.mozilla.org/r/130224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130224/

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8858246 [details]
Bug 1356520 - Set TOOLTOOL_CACHE to /home/worker/tooltool-cache where it makes sense in mozharness.

https://reviewboard.mozilla.org/r/130224/#review133004

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04bda21f77ae
Set TOOLTOOL_CACHE to /home/worker/tooltool-cache where it makes sense in mozharness. r=mshal

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/04bda21f77ae