1356534 - [Regression] Firefox will crash on Top Sites after first sync on iPad

Status: VERIFIED FIXED

(Firefox for iOS :: Home screen, defect, P1)

Description

[Simon Basca [:SimonB]]

Attachment: Client 14-04-2017, 11-35.crash

Build: 58b02370e25
Device: iPad Pro
iOS: 10.3

Steps to reproduce:
1. Install Firefox
2. Launch Firefox
3. Log in to FxA with sync data

Actual results: 
- Firefox will crash after first sync. 

Note:
- I am also logged in on desktop with this FxA.

Comment 1

[Simon Basca [:SimonB]]

Regression range:

- Last good build: BuddyBuild #2396
- First bad build: BuddyBuild #2605

Comment 2

[Simon Basca [:SimonB]]

Note: 
- I was unable to reproduce this on iPhone following the STR with the same FxA.

Comment 3

[Richard Newman [:rnewman]]

Can you reproduce this if you aren't on the home screen? The crash doesn't look anything to do with Sync.

Comment 4

[Simon Basca [:SimonB]]

(In reply to Richard Newman [:rnewman] from comment #3)
> Can you reproduce this if you aren't on the home screen? 

I am not reproducing this issue if I visit a page while the first sync occurs. I am reproducing this issue only on Top Sites.

Comment 5

[Simon Basca [:SimonB]]

Note:
- This issue is not related to a particular FxA. I manage to reproduce this issue using several test accounts.

Comment 6

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 7

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/04aa407e19b6e0497f7e15f4bfb8a2c9e8bd61cd

Comment 8

[Simon Basca [:SimonB]]

Verifying as fix on master b3b12590beb.