1356541 - Avoid MOZBUILD_STATE_PATH prompt on automation

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1356541 - Avoid MOZBUILD_STATE_PATH prompt on automation.

Review commit: https://reviewboard.mozilla.org/r/130260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130260/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8858271 [details]
Bug 1356541 - Avoid MOZBUILD_STATE_PATH prompt on automation.

https://reviewboard.mozilla.org/r/130260/#review133032

This seems fine. But my worry from landing this is that the state directory won't necessarily be created optimally in automation. For example, in TaskCluster, we arguably want the state directory on a cache so e.g. toolchains can be reused across tasks. If the default state directory (~/.mozbuild) is used, I'm pretty sure no caches will come into play and we'll be doing extra work on every task. By forcing automation to explicitly define the location of the state directory and ensure it is created, we require whoever set up that automation to (hopefully) consider and take advantage of caching (where appropriate).

If you feel similarly, consider dropping this change and changing whatever automation was complaining to populate MOZBUILD_STATE_PATH instead.

Comment 3

[Mike Hommey [:glandium]]

In practice, we already have the TC caching problem for other directories than this one, and this should be addressed case by case. I've been hit by this code running on automation more than once, and yesterday was one too many.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c332c0a3a67a
Avoid MOZBUILD_STATE_PATH prompt on automation. r=gps

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c332c0a3a67a