Closed Bug 1356541 Opened 3 years ago Closed 3 years ago

Avoid MOZBUILD_STATE_PATH prompt on automation

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8858271 [details]
Bug 1356541 - Avoid MOZBUILD_STATE_PATH prompt on automation.

https://reviewboard.mozilla.org/r/130260/#review133032

This seems fine. But my worry from landing this is that the state directory won't necessarily be created optimally in automation. For example, in TaskCluster, we arguably want the state directory on a cache so e.g. toolchains can be reused across tasks. If the default state directory (~/.mozbuild) is used, I'm pretty sure no caches will come into play and we'll be doing extra work on every task. By forcing automation to explicitly define the location of the state directory and ensure it is created, we require whoever set up that automation to (hopefully) consider and take advantage of caching (where appropriate).

If you feel similarly, consider dropping this change and changing whatever automation was complaining to populate MOZBUILD_STATE_PATH instead.
Attachment #8858271 - Flags: review?(gps) → review+
In practice, we already have the TC caching problem for other directories than this one, and this should be addressed case by case. I've been hit by this code running on automation more than once, and yesterday was one too many.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/c332c0a3a67a
Avoid MOZBUILD_STATE_PATH prompt on automation. r=gps
Blocks: 1356683
https://hg.mozilla.org/mozilla-central/rev/c332c0a3a67a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Summary: Avoid MOZBUID_STATE_PATH prompt on automation → Avoid MOZBUILD_STATE_PATH prompt on automation
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.