1356586 - Properly exclude dirs for babel transpilation

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is a follow up for bug 1356146

https://bugzilla.mozilla.org/show_bug.cgi?id=1356146#c12

Webpack.config doesn't work properly in Windows.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1356586 - Properly exclude dirs for babel transpilation;

Review commit: https://reviewboard.mozilla.org/r/130288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130288/

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8858329 [details]
Bug 1356586 - Properly exclude dirs for babel transpilation;

https://reviewboard.mozilla.org/r/130288/#review132978

It works on my Mac. Thanks!

::: devtools/client/netmonitor/webpack.config.js:120
(Diff revision 1)
>  webpackConfig.plugins = mappings.map(([regex, res]) =>
>    new NormalModuleReplacementPlugin(regex, res));
>  
> -// Exclude to transplie all scripts in devtools/ but not for this folder
> -webpackConfig.babelExcludes = new RegExp(
> -  `^${path.join(__dirname, "../../")}(.(?!${path.basename(__dirname)}))*$`);
> +// Exclude to transpile all scripts in devtools/ but not for this folder
> +const basePath = path.join(__dirname, "../../").replace(/\\/g, "\\\\");
> +const baseName =  path.basename(__dirname);

nit: remove this additional white space at `=  path`

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8858329 [details]
Bug 1356586 - Properly exclude dirs for babel transpilation;

https://reviewboard.mozilla.org/r/130288/#review132980

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8858329 [details]
Bug 1356586 - Properly exclude dirs for babel transpilation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130288/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a844eee0974
Properly exclude dirs for babel transpilation; r=rickychien

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5a844eee0974