135666 - Creating bugs: OS detection doesn't work for Internet Explorer, Win NT 4.0

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Johannes Pellenz]

If a new bug is entered from a PC running Windows NT 4.0 and Internet Explorer, 
the operating system cannot be detected (you get 'other').

The problem is that the browser identifies itself as
  Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 4.0)
which does not match in sub pickos in enter_bug.cgi.

One solution ist to change the line
            /Mozilla.*\(Windows.*NT/        && do {return "Windows NT";};
to
            /Mozilla.*Windows.*NT/          && do {return "Windows NT";};
so that no '(' is required the string 'Windows'.

Comment 1

[Dave Miller [:justdave]]

Timeless, this is probably yours :-)

Comment 2

[Dave Miller [:justdave]]

This was fixed in CVS back in November...

*** This bug has been marked as a duplicate of 107672 ***

Comment 3

[Johannes Pellenz]

I checked again with the 2.15 version from the CVS server, and the bug is still 
there. This time I will add a patch that fixes the problem.

Comment 4

[Johannes Pellenz]

Attachment: Patch so that Win NT OS is detected

Comment 5

[timeless]

ok, if we're going to tweak that line, then i'd like to tweak the line above it too. I'll look at this on sunday.

Comment 6

[David D. Kilzer (ddk)]

Attachment: Patch v.2

Fixed the line above as timeless requested.  Also "standardized"
the original line that was changed so that it matched the other
lines.

See this web page for a sampling of MSIE user agents:

  http://browserwatch.internet.com/stats/ua-microsoft.html

And for the record, Netscape/Mozilla user agents:

  http://browserwatch.internet.com/stats/ua-netscape.html

Comment 7

[David D. Kilzer (ddk)]

See also Bug 92763.

Comment 8

[Bradley Baetz (:bbaetz)]

Comment on attachment 78942 [details] [diff] [review]
Patch v.2

I can't test this (not having win2k available), but it looks reasonable.
r=bbaetz - does this work with mozilla on thpose platforms, too?

Comment 9

[Johannes Pellenz]

I tested Patch v.2 (attachment 78942 [details] [diff] [review]) using the following OS' and browsers:
  Win NT 4.0, IE 5.0,
  Win NT 4.0, Mozilla 0.9.9,
  Win2k, IE 5.0 and
  Win2k, Mozilla 0.9.9.
The OS detection worked correctly in all cases.

Comment 10

[Dave Miller [:justdave]]

This will be fixed by the patch on bug 92763, which happens to include the same
changes as the patch here, and has already been approved for checkin.

*** This bug has been marked as a duplicate of 92763 ***

Comment 11

[Bradley Baetz (:bbaetz)]

The patches are not identical. The other bug mathces on Windows XP and Windows
NT 5.1, to XP, whilst this patch changes the NT4 and 2K regexp so that the os is
not the first item in the brackets. (Although the 2K one probably already matches)

Reopening.

Comment 12

[Dave Miller [:justdave]]

Comment on attachment 78942 [details] [diff] [review]
Patch v.2

my mistake...  I wasn't reading that close enough.  Since these are two
separate things, this one looks good, too.

Comment 13

[timeless]

checked in