Remove console paste warning for unofficial branding

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Console
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: Oriol, Assigned: Oriol)

Tracking

32 Branch
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
Created attachment 8858389 [details] [diff] [review]
console-pasting-warning.patch

Bug 994134 introduced a very annoying warning which prevents pasting to the console.

Nightly and Aurora users are considered intelligent enough to know what they are doing, so they don't see the warning.

But users who compile Firefox themselves have the unofficial branding, which shows the warning just like in release.

That's nonsense. People who know how to build Firefox won't be scammed into entering malicious code to the console.

Just get rid of the annoying warning.
Attachment #8858389 - Flags: review?(nfitzgerald)
Attachment #8858389 - Flags: review?(nfitzgerald) → review?(bgrinstead)
Comment on attachment 8858389 [details] [diff] [review]
console-pasting-warning.patch

Review of attachment 8858389 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine with me.  Please do a try run to make sure tests aren't relying on this behavior
Attachment #8858389 - Flags: review?(bgrinstead) → review+
(Assignee)

Comment 2

2 months ago
(In reply to Brian Grinstead [:bgrins] from comment #1)
> Please do a try run to make sure tests aren't relying on this behavior

Is this addressed to me? I don't know how to do this.
(In reply to Oriol from comment #2)
> (In reply to Brian Grinstead [:bgrins] from comment #1)
> > Please do a try run to make sure tests aren't relying on this behavior
> 
> Is this addressed to me? I don't know how to do this.

OK I've pushed to try here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8f054ba0ef777e5842a23cf686e59069b02856c. Once that's done if it looks good we can mark checkin-needed on the bug
(Assignee)

Comment 4

2 months ago
The only fails seem a known problem (bug 1290863) and a timeout. I think this is good.
Keywords: checkin-needed

Comment 5

2 months ago
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0f666b2d3c2
Do not warn when pasting code into the console on unofficial branding, r=bgrins
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e0f666b2d3c2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.