Closed Bug 1356683 Opened 3 years ago Closed 3 years ago

Use the new tooltool wrapper instead of tooltool in most places

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(8 files, 1 obsolete file)

59 bytes, text/x-review-board-request
chmanchester
: review+
Details
59 bytes, text/x-review-board-request
chmanchester
: review+
Details
59 bytes, text/x-review-board-request
chmanchester
: review+
Details
59 bytes, text/x-review-board-request
chmanchester
: review+
Details
59 bytes, text/x-review-board-request
chmanchester
: review+
Details
59 bytes, text/x-review-board-request
chmanchester
: review+
Details
59 bytes, text/x-review-board-request
chmanchester
: review+
Details
59 bytes, text/x-review-board-request
chmanchester
: review+
Details
Splitting this off bug 1355731 so that the command itself can land.
Depends on: 1356700
Comment on attachment 8858412 [details]
Bug 1356683 - Use new tooltool wrapper for valgrind builds.

https://reviewboard.mozilla.org/r/130378/#review133102
Attachment #8858412 - Flags: review?(cmanchester) → review+
Comment on attachment 8858413 [details]
Bug 1356683 - Use new tooltool wrapper for Windows Spidermonkey builds.

https://reviewboard.mozilla.org/r/130380/#review133104
Attachment #8858413 - Flags: review?(cmanchester) → review+
Comment on attachment 8858414 [details]
Bug 1356683 - Use new tooltool wrapper in mozharness.

https://reviewboard.mozilla.org/r/130382/#review133106
Attachment #8858414 - Flags: review?(cmanchester) → review+
Comment on attachment 8858415 [details]
Bug 1356683 - Use new tooltool wrapper in Linux hazard builds.

https://reviewboard.mozilla.org/r/130384/#review133108
Attachment #8858415 - Flags: review?(cmanchester) → review+
Comment on attachment 8858416 [details]
Bug 1356683 - Use new tooltool wrapper in Linux Spidermonkey builds.

https://reviewboard.mozilla.org/r/130386/#review133110
Attachment #8858416 - Flags: review?(cmanchester) → review+
Comment on attachment 8858417 [details]
Bug 1356683 - Use new tooltool wrapper in Windows clang toolchain builds.

https://reviewboard.mozilla.org/r/130388/#review133112

::: taskcluster/ci/toolchain/windows.yml:21
(Diff revision 1)
>      run:
>          using: toolchain-script
>          script: build-clang32-windows.sh
>          resources:
>              - 'build/build-clang/**'
> +            - 'build/src/taskcluster/scripts/misc/build-clang-windows-helper32.sh'

Changes in this file seem like fodder for a separate commit. Not a show stopper of course.
Attachment #8858417 - Flags: review?(cmanchester) → review+
Comment on attachment 8858418 [details]
Bug 1356683 - Use new tooltool wrapper in Linux and OSX clang toolchain builds.

https://reviewboard.mozilla.org/r/130390/#review133114

Same comment about adding files to `resources` as a separate commit.
Attachment #8858418 - Flags: review?(cmanchester) → review+
Comment on attachment 8858419 [details]
Bug 1356683 - Use new tooltool wrapper in AWSY jobs.

https://reviewboard.mozilla.org/r/130392/#review133116
Attachment #8858419 - Flags: review?(cmanchester) → review+
Comment on attachment 8858420 [details]
Bug 1356683 - Use new tooltool wrapper for cctools builds.

https://reviewboard.mozilla.org/r/130394/#review133118
Attachment #8858420 - Flags: review?(cmanchester) → review+
(In reply to Chris Manchester (:chmanchester) from comment #15)
> Comment on attachment 8858417 [details]
> Bug 1356683 - Use new tooltool wrapper in Windows clang toolchain builds.
> 
> https://reviewboard.mozilla.org/r/130388/#review133112
> 
> ::: taskcluster/ci/toolchain/windows.yml:21
> (Diff revision 1)
> >      run:
> >          using: toolchain-script
> >          script: build-clang32-windows.sh
> >          resources:
> >              - 'build/build-clang/**'
> > +            - 'build/src/taskcluster/scripts/misc/build-clang-windows-helper32.sh'
> 
> Changes in this file seem like fodder for a separate commit. Not a show
> stopper of course.

Removed from the updated patches. Will file a separate bug.
Depends on: 1356720
Depends on: 1356933
Attachment #8858420 - Attachment is obsolete: true
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/36f010980dcd
Use new tooltool wrapper for valgrind builds. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/35bb80a39be6
Use new tooltool wrapper for Windows Spidermonkey builds. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/d51d444bd5b5
Use new tooltool wrapper in mozharness. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/b4a1bde02085
Use new tooltool wrapper in Linux hazard builds. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/37a8a76210fb
Use new tooltool wrapper in Linux Spidermonkey builds. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/b5047f4eeece
Use new tooltool wrapper in Windows clang toolchain builds. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/70969dad9f5a
Use new tooltool wrapper in Linux and OSX clang toolchain builds. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/3441bd2b242a
Use new tooltool wrapper in AWSY jobs. r=chmanchester
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.