Closed
Bug 1356690
Opened 9 years ago
Closed 7 years ago
Confidential bug checking is performed redundantly, adds significant latency to publishing
Categories
(MozReview Graveyard :: General, enhancement)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: gps, Unassigned)
Details
Looking at server logs, it appears we are performing confidential bug checks for every review request in a series. This appears to occur during at least the posting review request to bug code path.
On the log I'm looking at now, there are 7 "Checking if bug 1323339 is confidential" messages in the log. Each takes 200-300ms before "Bug 1323339 confidential: False" is printed. That means we're wasting 6*250ms = 1.5s during publishing of this series redundantly checking the bug's confidential state. Of course, the waste will be less for smaller series and greater for larger series.
We should cache and reuse the bug confidential lookup so it is performed at most once during series events.
|
||
Comment 1•7 years ago
|
||
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•