1356761 - Find a better capacity for custom element reactions stack and queues

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[John Dai[:jdai]]

Per bug 1309147 comment #99, we need to find a better capacity for custom element reactions stack, custom element reaction queue, element queue, and backup element queue[1] in order to have better performance and less wasting space.


[1] https://html.spec.whatwg.org/multipage/scripting.html#custom-element-reactions

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Is this something that should block bug 1396567?

Comment 2

[John Dai[:jdai]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #1)
> Is this something that should block bug 1396567?

Yes, this bug should be blocked by bug 1396567. Thank you.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: custom_reaction_stack_element_queue.diff

This should be reasonable for reactionstack.
We do use ElementQueue also for backup queue, and there we may have more stuff

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8980676 [details] [diff] [review]
custom_reaction_stack_element_queue.diff

Review of attachment 8980676 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/CustomElementRegistry.h
@@ +225,5 @@
>    // Hold a strong reference of Element so that it does not get cycle collected
>    // before the reactions in its reaction queue are invoked.
>    // The element reaction queues are stored in CustomElementData.
>    // We need to lookup ElementReactionQueueMap again to get relevant reaction queue.
>    // The choice of 1 for the auto size here is based on gut feeling.

Please update the comment.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

oops, will do.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: custom_reaction_stack_element_queue_3.diff

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5f7144573e6
better AutoTArray capacity for ElementQueue, r=mrbkap

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/c5f7144573e6