Closed Bug 1356761 Opened 3 years ago Closed 2 years ago

Find a better capacity for custom element reactions stack and queues

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jdai, Assigned: smaug)

References

Details

Attachments

(2 files)

Per bug 1309147 comment #99, we need to find a better capacity for custom element reactions stack, custom element reaction queue, element queue, and backup element queue[1] in order to have better performance and less wasting space.


[1] https://html.spec.whatwg.org/multipage/scripting.html#custom-element-reactions
Is this something that should block bug 1396567?
Flags: needinfo?(jdai)
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #1)
> Is this something that should block bug 1396567?

Yes, this bug should be blocked by bug 1396567. Thank you.
Blocks: 1396567
Flags: needinfo?(jdai)
Priority: -- → P2
Priority: P2 → P3
Assignee: jdai → nobody
Status: ASSIGNED → NEW
This should be reasonable for reactionstack.
We do use ElementQueue also for backup queue, and there we may have more stuff
Attachment #8980676 - Flags: review?(mrbkap)
Comment on attachment 8980676 [details] [diff] [review]
custom_reaction_stack_element_queue.diff

Review of attachment 8980676 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/CustomElementRegistry.h
@@ +225,5 @@
>    // Hold a strong reference of Element so that it does not get cycle collected
>    // before the reactions in its reaction queue are invoked.
>    // The element reaction queues are stored in CustomElementData.
>    // We need to lookup ElementReactionQueueMap again to get relevant reaction queue.
>    // The choice of 1 for the auto size here is based on gut feeling.

Please update the comment.
Attachment #8980676 - Flags: review?(mrbkap) → review+
oops, will do.
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5f7144573e6
better AutoTArray capacity for ElementQueue, r=mrbkap
https://hg.mozilla.org/mozilla-central/rev/c5f7144573e6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Assignee: nobody → bugs
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.