1356766 - Support HTMLTooltop when running launchpad on Chrome

Status: VERIFIED FIXED

(DevTools :: Netmonitor, enhancement, P1)

Description

[Ricky Chien [:rickychien] (inactive)]

HTMLTooltip is using a getBoxQuads non-standard API to calculate relative position. We should find an alternative to support getBoxQuads when running launchpad on Chrome.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1356766 - Support HTMLTooltop when running launchpad on Chrome

Review commit: https://reviewboard.mozilla.org/r/130454/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130454/

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Here is an elegant solution to skip getBoxQuads() call in HTMLTooltip.js. When running in HTML document, getBoundingClientRect() will position properly and return correct top, right, bottom, left, width, height properties for us. But it doesn't work when tooltip is appended on XUL document. Thus, we can fallback to call getBoxQuads() to get the right position.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Attachment: Screen Shot 2017-04-15 at 3.35.16 PM.png

As attachment, tooltip can show properly when running on Chrome.

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 8858488 [details]
Bug 1356766 - Support HTMLTooltop when running launchpad on Chrome

https://reviewboard.mozilla.org/r/130454/#review133136

::: devtools/client/shared/widgets/tooltip/HTMLTooltip.js:181
(Diff revision 1)
>  const getRelativeRect = function (node, relativeTo) {
> +  // In order to support launchpad, we can skip getBoxQuads when appending
> +  // Tooltip on HTML document.
> +  // getBoxQuads is a non-standard WebAPI which will not work on non-firefox
> +  // browser.
> +  if (relativeTo.documentElement.namespaceURI !== XUL_NS) {

I think it makes more sense to do:

if (!node.getBoundingRect)

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8858488 [details]
Bug 1356766 - Support HTMLTooltop when running launchpad on Chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130454/diff/1-2/

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8858488 [details]
Bug 1356766 - Support HTMLTooltop when running launchpad on Chrome

https://reviewboard.mozilla.org/r/130454/#review133136

> I think it makes more sense to do:
> 
> if (!node.getBoundingRect)

Nice catch!

Comment 7

[Tim Nguyen :ntim]

Comment on attachment 8858488 [details]
Bug 1356766 - Support HTMLTooltop when running launchpad on Chrome

https://reviewboard.mozilla.org/r/130454/#review133140

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d8211a95992
Support HTMLTooltop when running launchpad on Chrome r=ntim

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8d8211a95992

Comment 10

[Ciprian Georgiu, Desktop QA]

I can confirm that HTML tooltip is working accordingly when running launchpad ("devtools-launchpad": "=0.0.75") on Chrome.
Marking this as verified fixed on 55 beta 7 (20170706155135) across platforms: Windows 10 x64, Mac OS X 10.11.5 and Ubuntu 16.04 x64.