1356786 - Add waitUntil in browser_webconsole_shows_reqs_in_netmonitor.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Ricky Chien [:rickychien] (inactive)]

Fix intermittent issue in bug 1307800. Let's add this waitUntil to wait and see whether it fixes the intermittent error in browser_webconsole_shows_reqs_in_netmonitor.js.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1356786 - Add waitUntil in browser_webconsole_shows_reqs_in_netmonitor.js

Review commit: https://reviewboard.mozilla.org/r/130480/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130480/

Comment 2

[Ricky Chien [:rickychien] (inactive)]

I suspect that intermittent happens since we don't wait for network request arrived and gStore.getState().requests.requests.size hasn't increased to 1. So adding a waitUntil() could fix this issue.

Comment 3

[Tim Nguyen :ntim]

Comment on attachment 8858506 [details]
Bug 1356786 - Add waitUntil in browser_webconsole_shows_reqs_in_netmonitor.js

https://reviewboard.mozilla.org/r/130480/#review133148

::: devtools/client/webconsole/test/browser_webconsole_shows_reqs_in_netmonitor.js:68
(Diff revision 1)
> -
>    let { gStore, windowRequire } = monitor.panelWin;
> -  let Actions = windowRequire("devtools/client/netmonitor/src/actions/index");
>    let { getSortedRequests } = windowRequire("devtools/client/netmonitor/src/selectors/index");
>  
> -  gStore.dispatch(Actions.batchEnable(false));
> +  yield waitUntil(() => gStore.getState().requests.requests.size > 0);

Why do we have to re-enable batch actions to fix the intermittent ?

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8858506 [details]
Bug 1356786 - Add waitUntil in browser_webconsole_shows_reqs_in_netmonitor.js

https://reviewboard.mozilla.org/r/130480/#review133150

::: devtools/client/webconsole/test/browser_webconsole_shows_reqs_in_netmonitor.js:68
(Diff revision 1)
> -
>    let { gStore, windowRequire } = monitor.panelWin;
> -  let Actions = windowRequire("devtools/client/netmonitor/src/actions/index");
>    let { getSortedRequests } = windowRequire("devtools/client/netmonitor/src/selectors/index");
>  
> -  gStore.dispatch(Actions.batchEnable(false));
> +  yield waitUntil(() => gStore.getState().requests.requests.size > 0);

I just think that waitUntil() will wait for network requests so that make this disable batching to becom useless. No matter actions are sync or async, in the end we still need to wait getState().requests.requests.size > 0.

I hope that sounds reasonable to you:)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/176e3dc6dc94
Add waitUntil in browser_webconsole_shows_reqs_in_netmonitor.js r=ntim

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/176e3dc6dc94

Comment 7

[Ryan VanderMeulen [:RyanVM]]

No occurrences of bug 1307800 on trunk since 15-April :)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/659b94994878