1356827 - Don't load the blocklist service before we need it

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Kris Maglione [:kmag]]

We currently eagerly load the blocklist service at startup just to access some nsIBlocklistService constants, even though we don't actually need the service itself.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1356827: Don't load the blocklist service before we need it.

Review commit: https://reviewboard.mozilla.org/r/130526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130526/

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 8858543 [details]
Bug 1356827: Don't load the blocklist service before we need it.

https://reviewboard.mozilla.org/r/130526/#review133174

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/504db6862787
Don't load the blocklist service before we need it. r=rhelmer

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/504db6862787

Comment 5

[Vasilica Tamas, QA [:vtamas]]

Is there necessary any manual testing around this bug? If yes, could you please provide some reliable steps?

Comment 6

[Andy McKay]

Sorry, reviewing the patch, the qawanted flag is probably unwarranted, the change is so small. I added it because blocklist, would suck if that breaks. If you wanted to just do a quick smoke test that the block list still works that's cool. I'll remove the flag.

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8858543 [details]
Bug 1356827: Don't load the blocklist service before we need it.

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: This change improves startup performance, and should help mitigate the startup performance regressions from enabling Screenshots in beta.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: N/A
[Needs manual test from QE? If yes, steps to reproduce]: N/A
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is a trivial change to how we access a set of interface constants, which fixes the lazy loading that we were already supposed to be doing.
[String changes made/needed]: None

Comment 8

[Gerry Chang [:gchang]]

Screenshots will go live in Fx55 so we don't have to uplift these patches in 54. Beta54-. Mark 54 won't fix.