Closed
Bug 1356933
Opened 8 years ago
Closed 8 years ago
Use tooltool-download.sh helper in cctools build scripts
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8858685 [details]
Bug 1356933 - Use tooltool-download.sh helper in cctools build scripts.
https://reviewboard.mozilla.org/r/130686/#review133510
Attachment #8858685 -
Flags: review?(cmanchester) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/14010d77d56a
Use tooltool-download.sh helper in cctools build scripts. r=chmanchester
Comment 4•8 years ago
|
||
backed out for invisible bustage, which was supposed to be triggered by the same patch, but didn't happen
https://hg.mozilla.org/integration/autoland/rev/92f94fc0993b
Flags: needinfo?(mh+mozilla)
Assignee | ||
Comment 5•8 years ago
|
||
So, somehow those jobs, on top of being hidden on treeherder, don't have access to relengapi...
Flags: needinfo?(mh+mozilla)
Assignee | ||
Comment 6•8 years ago
|
||
Interesting mess.
- The linux build failed because of a missing tooltool-downloads: public in the taskcluster definition
- The mac build failed because the cctools it uses has a rpath pointing to /home/worker/workspace/clang/lib, which doesn't exist after the patch, since clang is now unpacked in /home/worker/workspace/build/src/clang.
A few funny notes about the whole situation:
- Cross-mac builds work with the same cctools because they set LD_LIBRARY_PATH
- Ironically, after the patch, cctools has a rpath pointing to /home/worker/workspace/build/src/clang/lib, and it all worked fine on my try pushes because... I had bug 1313111 pushed along, making the mac cctools build use the result of the linux cctools build...
Let's go with a LD_LIBRARY_PATH in the meanwhile...
Assignee | ||
Comment 7•8 years ago
|
||
Filed bug 1357317 for a long term solution.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8858685 -
Flags: review+ → review?(cmanchester)
Comment 10•8 years ago
|
||
mozreview-review |
Comment on attachment 8858685 [details]
Bug 1356933 - Use tooltool-download.sh helper in cctools build scripts.
https://reviewboard.mozilla.org/r/130686/#review134400
Attachment #8858685 -
Flags: review?(cmanchester) → review+
Comment 12•8 years ago
|
||
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/678b26af371a
Use tooltool-download.sh helper in cctools build scripts. r=chmanchester
Comment 13•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•