1357194 - AccessibleHandler CLSID not working as intended

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Looks like the problem was that I had a misunderstanding about how we distinguish local builds from Nightly builds.

I also want to add a set of GUIDs to make beta and release distinct.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1357194: Use MOZ_UPDATE_CHANNEL to distinguish between local/nightly and beta/release builds for AccessibleHandler CLSIDs

I want AccessibleHandler.dll to use different UUIDs based on release channel.
The way I was doing it before wasn't working correctly because I also wanted
local builds to have their own set of UUIDs vs our regular Nightly/Beta/Release
builds.

I also want the beta channel to have its own set of UUIDs that are distinct
from release.

I'm using MOZ_UPDATE_CHANNEL to distinguish between the channels when
NIGHTLY_BUILD and BETA_OR_RELEASE are insufficient.

Review commit: https://reviewboard.mozilla.org/r/130908/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130908/

Comment 2

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8858917 [details]
Bug 1357194: Use MOZ_UPDATE_CHANNEL to distinguish between local/nightly and beta/release builds for AccessibleHandler CLSIDs

https://reviewboard.mozilla.org/r/130908/#review133502

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8858917 [details]
Bug 1357194: Use MOZ_UPDATE_CHANNEL to distinguish between local/nightly and beta/release builds for AccessibleHandler CLSIDs

https://reviewboard.mozilla.org/r/130908/#review133884

::: accessible/ipc/win/handler/moz.build:53
(Diff revision 1)
>  # but we still want to be able to delegate some work to the generated code,
>  # we add the prefix "Proxy" to all of the generated counterparts.
>  DEFINES['ENTRY_PREFIX'] = 'Proxy'
>  DEFINES['REGISTER_PROXY_DLL'] = True
>  
> +if CONFIG['MOZ_UPDATE_CHANNEL'] == 'default':

This block should probably have a comment, since it's not clear from just looking at the moz.build file why you would only set a value for 'default' and 'beta'.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8858917 [details]
Bug 1357194: Use MOZ_UPDATE_CHANNEL to distinguish between local/nightly and beta/release builds for AccessibleHandler CLSIDs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130908/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9434a31807d5
Use MOZ_UPDATE_CHANNEL to distinguish between local/nightly and beta/release builds for AccessibleHandler CLSIDs; r=mhowell,mshal

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9434a31807d5