Make v-c-t development environment more flexible

RESOLVED FIXED

Status

Developer Services
General
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(9 attachments)

59 bytes, text/x-review-board-request
glob
: review+
Details | Review
59 bytes, text/x-review-board-request
glob
: review+
Details | Review
59 bytes, text/x-review-board-request
glob
: review+
Details | Review
59 bytes, text/x-review-board-request
glob
: review+
Details | Review
59 bytes, text/x-review-board-request
glob
: review+
Details | Review
59 bytes, text/x-review-board-request
glob
: review+
Details | Review
59 bytes, text/x-review-board-request
glob
: review+
Details | Review
59 bytes, text/x-review-board-request
glob
: review+
Details | Review
59 bytes, text/x-review-board-request
glob
: review+
Details | Review
(Assignee)

Description

8 months ago
version-control-tools has expanded and now contains functionality for a number of  different projects. Each project has its own specific needs. I no longer think it is appropriate to shoehorn functionality for all of these projects into a single environment.

I will be submitting patches to support multiple "environments" from within v-c-t. My initial goal is to make standalone vcssync development more tolerable (no worries about Docker, etc). But I plan to extend this to other things as well (such as making Mercurial hook development simpler).
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 10

8 months ago
FWIW I have other improvements I want to make here. But I figured I should hold off and make sure I get buy-in to the idea before investing any more time in it.

Comment 11

8 months ago
mozreview-review
Comment on attachment 8858941 [details]
run-tests: use hg executable from active virtualenv (bug 1357201);

https://reviewboard.mozilla.org/r/130934/#review133592
Attachment #8858941 - Flags: review?(glob) → review+

Comment 12

8 months ago
mozreview-review
Comment on attachment 8858942 [details]
run-tests: make Docker an optional dependency (bug 1357201);

https://reviewboard.mozilla.org/r/130936/#review134156
Attachment #8858942 - Flags: review?(glob) → review+

Comment 13

8 months ago
mozreview-review
Comment on attachment 8858943 [details]
testing: make create-virtualenv usable as a standalone script (bug 1357201);

https://reviewboard.mozilla.org/r/130938/#review134158
Attachment #8858943 - Flags: review?(glob) → review+

Comment 14

8 months ago
mozreview-review
Comment on attachment 8858944 [details]
global: support creating virtualenv for vcssync (bug 1357201);

https://reviewboard.mozilla.org/r/130940/#review134154

::: create-environment:21
(Diff revision 1)
> +)
> +
> +
> +def main():
> +    parser = argparse.ArgumentParser()
> +    parser.add_argument('name', choices=('vcssync'),

this should be choices=['vcssync'].
current code expands to {v,c,s,s,y,n,c}
Attachment #8858944 - Flags: review?(glob) → review+

Comment 15

8 months ago
mozreview-review
Comment on attachment 8858945 [details]
ansible/vcs-sync: use vcssync/prod-requirements.txt (bug 1357201);

https://reviewboard.mozilla.org/r/130942/#review134164
Attachment #8858945 - Flags: review?(glob) → review+

Comment 16

8 months ago
mozreview-review
Comment on attachment 8858946 [details]
testing: detect missing virtualenv differently (bug 1357201);

https://reviewboard.mozilla.org/r/130944/#review134168
Attachment #8858946 - Flags: review?(glob) → review+

Comment 17

8 months ago
mozreview-review
Comment on attachment 8858947 [details]
run-tests: detect active virtualenv (bug 1357201);

https://reviewboard.mozilla.org/r/130946/#review134170
Attachment #8858947 - Flags: review?(glob) → review+

Comment 18

8 months ago
mozreview-review
Comment on attachment 8858948 [details]
testing: take virtualenv into account when finding tests (bug 1357201);

https://reviewboard.mozilla.org/r/130948/#review134178
Attachment #8858948 - Flags: review?(glob) → review+

Comment 19

8 months ago
mozreview-review
Comment on attachment 8858949 [details]
testing: remove vcssync dependencies from global environment (bug 1357201);

https://reviewboard.mozilla.org/r/130950/#review134180
Attachment #8858949 - Flags: review?(glob) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 26

8 months ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/e241282d2a91
run-tests: use hg executable from active virtualenv ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/3aec1f71cf88
run-tests: make Docker an optional dependency ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/6a634f6578a9
testing: make create-virtualenv usable as a standalone script ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/c55c7c8a5fb1
global: support creating virtualenv for vcssync ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/154bf339ee75
ansible/vcs-sync: use vcssync/prod-requirements.txt ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/d1763b870d1b
testing: detect missing virtualenv differently ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/5789eb3357f0
run-tests: detect active virtualenv ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/9aa1d39fd32f
testing: take virtualenv into account when finding tests ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/27778b64a0ec
testing: remove vcssync dependencies from global environment ; r=glob
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
(Assignee)

Updated

8 months ago
Blocks: 1360062
You need to log in before you can comment on or make changes to this bug.