Closed Bug 1357208 Opened 3 years ago Closed 3 years ago

637,100 instances of "'NS_FAILED(rv)'" emitted from caps/BasePrincipal.cpp during linux64 and win32 debug testing

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: erahm, Assigned: baku)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

> 166217 WARNING: 'NS_FAILED(rv)', file caps/BasePrincipal.cpp, line 380

This warning [1] shows up in the following test suites:

>   6123 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
>   5307 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
>   5090 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
>   4990 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
>   4798 - test-linux64/debug-mochitest-browser-chrome-14 bc14
>   4697 - test-linux64/debug-mochitest-browser-chrome-15 bc15
>   4258 - test-linux64/debug-mochitest-jetpack JP
>   3945 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
>   3916 - test-linux64/debug-mochitest-browser-chrome-16 bc16
>   3536 - test-linux64/debug-mochitest-devtools-chrome-5 dt5
>   3443 - test-linux64/debug-mochitest-browser-chrome-1 bc1
>   2901 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>   2846 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
>   2755 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
>   2741 - test-linux64/debug-mochitest-devtools-chrome-6 dt6
>   2700 - test-linux64/debug-mochitest-devtools-chrome-2 dt2
>   2688 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>   2679 - test-linux64/debug-mochitest-devtools-chrome-10 dt10
>   2604 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
>   2573 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
>   2569 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>   2568 - test-linux64/debug-mochitest-e10s-10 10
>   2416 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>   2384 - test-linux64/debug-mochitest-browser-chrome-7 bc7
>   2284 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
>   2254 - test-linux64/debug-mochitest-chrome-3 c3
>   2219 - test-linux64/debug-mochitest-devtools-chrome-8 dt8
>   2140 - test-linux64/debug-mochitest-devtools-chrome-1 dt1
>   2139 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
>   2138 - test-linux64/debug-mochitest-devtools-chrome-7 dt7
>   2128 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
>   2112 - test-linux64/debug-mochitest-devtools-chrome-3 dt3
>   2111 - test-linux64/debug-mochitest-browser-chrome-2 bc2
>   2057 - test-linux64/debug-mochitest-chrome-1 c1
>   2039 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
>   1991 - test-linux64/debug-mochitest-browser-chrome-11 bc11
>   1986 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>   1904 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>   1892 - test-linux64/debug-mochitest-devtools-chrome-4 dt4
>   1793 - test-linux64/debug-mochitest-browser-chrome-3 bc3
>   1786 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
>   1765 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
>   1748 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>   1738 - test-linux64/debug-mochitest-browser-chrome-8 bc8
>   1666 - test-linux64/debug-mochitest-clipboard cl
>   1610 - test-linux64/debug-mochitest-browser-chrome-6 bc6
>   1585 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
>   1525 - test-linux64/debug-mochitest-browser-chrome-9 bc9
>   1497 - test-linux64/debug-mochitest-clipboard-e10s cl
>   1483 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
>   1478 - test-linux64/debug-mochitest-browser-chrome-13 bc13
>   1475 - test-linux64/debug-mochitest-browser-chrome-10 bc10
>   1465 - test-linux64/debug-mochitest-10 10
>   1318 - test-linux64/debug-mochitest-5 5
>   1272 - test-linux64/debug-mochitest-browser-chrome-4 bc4
>   1173 - test-linux64/debug-mochitest-chrome-2 c2
>   1172 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
>   1163 - test-linux64/debug-mochitest-browser-chrome-12 bc12
>   1141 - test-linux64/debug-mochitest-2 2
>   1096 - test-linux64/debug-mochitest-devtools-chrome-9 dt9
>   1043 - test-linux64/debug-mochitest-3 3
>   1031 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
>   1022 - test-linux64/debug-mochitest-1 1
>    975 - test-linux64/debug-mochitest-e10s-1 1
>    947 - test-linux64/debug-mochitest-browser-chrome-5 bc5
>    906 - test-linux64/debug-mochitest-e10s-3 3
>    684 - test-linux64/debug-mochitest-e10s-5 5
>    649 - test-linux64/debug-reftest-1 R1
>    649 - test-linux64/debug-reftest-no-accel-1 Ru1
>    645 - test-linux64/debug-crashtest C
>    620 - test-linux64/debug-mochitest-8 8
>    589 - test-linux64/debug-mochitest-6 6
>    507 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
>    507 - test-linux64/debug-reftest-e10s-1 R1
>    492 - test-linux64/debug-crashtest-e10s C
>    490 - test-linux64/debug-mochitest-e10s-8 8
>    481 - test-linux64/debug-mochitest-e10s-6 6
>    451 - test-linux64/debug-mochitest-7 7
>    433 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
>    400 - test-linux64/debug-mochitest-e10s-2 2
>    391 - test-linux64/debug-mochitest-a11y a11y
>    384 - test-linux64/debug-mochitest-9 9
>    377 - test-linux64/debug-mochitest-e10s-9 9
>    366 - test-linux64/debug-firefox-ui-functional-local en-US
>    355 - test-linux64/debug-mochitest-e10s-7 7
>    333 - test-linux64/debug-mochitest-4 4
>    286 - test-linux64/debug-mochitest-webgl-1 gl1
>    273 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
>    271 - test-linux64/debug-mochitest-webgl-2 gl2
>    257 - test-linux64/debug-mochitest-webgl-3 gl3
>    207 - test-linux64/debug-mochitest-e10s-4 4
>    200 - test-linux64/debug-mochitest-media-2 mda2
>    185 - test-linux64/debug-reftest-no-accel-5 Ru5
>    185 - test-linux64/debug-reftest-5 R5
>    169 - test-linux64/debug-mochitest-media-1 mda1
>    145 - test-linux64/debug-mochitest-gpu-e10s gpu
>    119 - test-linux64/debug-mochitest-media-3 mda3
>    103 - test-linux64/debug-firefox-ui-functional-remote en-US
>     85 - test-linux64/debug-mochitest-media-e10s-3 mda3
>     70 - test-linux64/debug-reftest-no-accel-3 Ru3
>     70 - test-linux64/debug-reftest-3 R3
>     52 - test-linux64/debug-mochitest-webgl-e10s-3 gl3
>     51 - test-linux64/debug-reftest-no-accel-4 Ru4
>     51 - test-linux64/debug-reftest-4 R4
>     49 - test-linux64/debug-reftest-7 R7
>     49 - test-linux64/debug-reftest-no-accel-7 Ru7
>     49 - test-linux64/debug-mochitest-media-e10s-2 mda2
>     47 - test-linux64/debug-mochitest-media-e10s-1 mda1
>     42 - test-linux64/debug-reftest-no-accel-8 Ru8
>     42 - test-linux64/debug-reftest-8 R8
>     37 - test-linux64/debug-reftest-e10s-8 R8
>     37 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>     36 - test-linux64/debug-reftest-no-accel-6 Ru6
>     36 - test-linux64/debug-reftest-6 R6
>     33 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
>     33 - test-linux64/debug-reftest-e10s-4 R4
>     31 - test-linux64/debug-reftest-e10s-3 R3
>     31 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
>     28 - test-linux64/debug-reftest-e10s-5 R5
>     28 - test-linux64/debug-reftest-e10s-6 R6
>     28 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
>     28 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
>     26 - test-linux64/debug-mochitest-webgl-e10s-1 gl1
>     23 - test-linux64/debug-reftest-e10s-7 R7
>     23 - test-linux64/debug-reftest-2 R2
>     23 - test-linux64/debug-reftest-e10s-2 R2
>     23 - test-linux64/debug-reftest-no-accel-2 Ru2
>     23 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
>     23 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
>     13 - test-linux64/debug-mochitest-webgl-e10s-2 gl2

It shows up in 10979 tests. A few of the most prevalent:

>   6096 -        Shutdown
>   4675 - [e10s] Shutdown
>   1533 -        jetpack-package/addon-sdk/source/test/test-simple-prefs.js.testUnloadOfDynamicPrefGeneration
>    420 - [e10s] browser/components/sessionstore/test/browser_354894_perwindowpb.js
>    409 - [e10s] toolkit/mozapps/extensions/test/browser/browser_discovery.js
>    396 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/dom/workers/test/crashtests/1228456.html
>    396 -        file:///home/worker/workspace/build/tests/reftest/tests/dom/workers/test/crashtests/1228456.html
>    354 - [e10s] toolkit/mozapps/extensions/test/browser/browser_bug562797.js
>    313 -        browser/components/sessionstore/test/browser_354894_perwindowpb.js
>    312 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-item-intrinsic-size-normal-002.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-item-intrinsic-size-normal-002-ref.html

[1] https://hg.mozilla.org/mozilla-central/annotate/cac374fb0de1/caps/BasePrincipal.cpp#l380
Andrea, bisection points to bug 1347817. This is by far the most verbose warning right now.
Blocks: 1347817
Flags: needinfo?(amarchesini)
And on Windows we have:

> 470856 WARNING: 'NS_FAILED(rv)', file caps/BasePrincipal.cpp, line 380

This warning [1] shows up in the following test suites:

>  10036 - Mochitest e10s Browser Chrome bc7
>  10025 - test-windows7-32-vm/debug-mochitest-browser-chrome-e10s-7 bc7
>  10000 - Mochitest e10s Browser Chrome bc4
>   9984 - test-windows7-32-vm/debug-mochitest-browser-chrome-e10s-4 bc4
>   8458 - Mochitest e10s Browser Chrome bc3
>   8448 - test-windows7-32-vm/debug-mochitest-browser-chrome-e10s-3 bc3
>   7625 - W3C Web Platform Tests 8
>   7160 - Mochitest Browser Chrome bc2
>   7157 - test-windows7-32-vm/debug-mochitest-browser-chrome-2 bc2
>   6915 - Mochitest e10s Browser Chrome bc5
>   6901 - test-windows7-32-vm/debug-mochitest-browser-chrome-e10s-5 bc5
>   6775 - test-windows7-32-vm/debug-mochitest-browser-chrome-1 bc1
>   6772 - Mochitest Browser Chrome bc1
>   6694 - Mochitest e10s Browser Chrome bc2
>   6690 - test-windows7-32-vm/debug-mochitest-browser-chrome-e10s-2 bc2
>   6652 - Mochitest Browser Chrome bc4
>   6650 - test-windows7-32-vm/debug-mochitest-browser-chrome-4 bc4
>   6226 - W3C Web Platform Tests e10s 8
>   6163 - test-windows7-32-vm/debug-mochitest-browser-chrome-e10s-1 bc1
>   6156 - Mochitest e10s Browser Chrome bc1
>   5869 - test-windows7-32-vm/debug-web-platform-tests-10 wpt10
>   5126 - W3C Web Platform Tests e10s 1
>   5117 - W3C Web Platform Tests 1
>   4839 - test-windows7-32-vm/debug-mochitest-browser-chrome-7 bc7
>   4834 - Mochitest Browser Chrome bc7
>   4781 - W3C Web Platform Tests 9
>   4763 - W3C Web Platform Tests e10s 9
>   4733 - Mochitest Browser Chrome bc3
>   4732 - test-windows7-32-vm/debug-mochitest-browser-chrome-3 bc3
>   4706 - Mochitest Browser Chrome bc5
>   4701 - test-windows7-32-vm/debug-mochitest-browser-chrome-5 bc5
>   4495 - test-windows7-32-vm/debug-mochitest-browser-chrome-e10s-6 bc6
>   4490 - W3C Web Platform Tests 7
>   4490 - Mochitest e10s Browser Chrome bc6
>   4490 - test-windows7-32-vm/debug-web-platform-tests-11 wpt11
>   4446 - W3C Web Platform Tests 2
>   4400 - test-windows7-32-vm/debug-web-platform-tests-e10s-10 wpt10
>   4399 - W3C Web Platform Tests e10s 2
>   4260 - Mochitest Jetpack JP
>   4258 - test-windows7-32-vm/debug-mochitest-jetpack JP
>   4249 - Mochitest Browser Chrome bc6
>   4248 - test-windows7-32-vm/debug-mochitest-browser-chrome-6 bc6
>   4221 - test-windows7-32-vm/debug-web-platform-tests-e10s-11 wpt11
>   4155 - W3C Web Platform Tests e10s 7
>   4042 - W3C Web Platform Tests 4
>   4017 - W3C Web Platform Tests e10s 4
>   3765 - test-windows7-32-vm/debug-web-platform-tests-6 wpt6
>   3754 - test-windows7-32-vm/debug-web-platform-tests-e10s-6 wpt6
>   3699 - test-windows7-32-vm/debug-web-platform-tests-9 wpt9
>   3684 - W3C Web Platform Tests e10s 5
>   3639 - W3C Web Platform Tests 6
>   3558 - W3C Web Platform Tests 5
>   3505 - W3C Web Platform Tests e10s 6
>   3366 - test-windows7-32-vm/debug-web-platform-tests-5 wpt5
>   3361 - test-windows7-32-vm/debug-web-platform-tests-3 wpt3
>   3359 - test-windows7-32-vm/debug-web-platform-tests-e10s-3 wpt3
>   3179 - Mochitest DevTools Browser Chrome dt3
>   3178 - test-windows7-32-vm/debug-mochitest-devtools-chrome-3 dt3
>   3171 - Mochitest DevTools Browser Chrome dt1
>   3165 - test-windows7-32-vm/debug-mochitest-devtools-chrome-1 dt1
>   3120 - test-windows7-32-vm/debug-web-platform-tests-7 wpt7
>   3117 - Mochitest e10s DevTools Browser Chrome dt2
>   3110 - Mochitest e10s DevTools Browser Chrome dt5
>   3069 - test-windows7-32-vm/debug-web-platform-tests-e10s-7 wpt7
>   3059 - Mochitest e10s 5
>   3058 - test-windows7-32-vm/debug-mochitest-e10s-5 5
>   3058 - Mochitest DevTools Browser Chrome dt5
>   3058 - Mochitest DevTools Browser Chrome dt4
>   3057 - test-windows7-32-vm/debug-mochitest-devtools-chrome-4 dt4
>   3053 - test-windows7-32-vm/debug-mochitest-devtools-chrome-5 dt5
>   3040 - test-windows7-32-vm/debug-web-platform-tests-2 wpt2
>   3013 - test-windows7-32-vm/debug-web-platform-tests-e10s-5 wpt5
>   2992 - test-windows7-32-vm/debug-web-platform-tests-e10s-2 wpt2
>   2938 - test-windows7-32-vm/debug-web-platform-tests-e10s-9 wpt9
>   2922 - W3C Web Platform Tests 3
>   2920 - test-windows7-32-vm/debug-mochitest-devtools-chrome-2 dt2
>   2919 - Mochitest DevTools Browser Chrome dt2
>   2908 - Mochitest DevTools Browser Chrome dt6
>   2906 - test-windows7-32-vm/debug-mochitest-devtools-chrome-6 dt6
>   2904 - W3C Web Platform Tests e10s 3
>   2886 - Mochitest e10s DevTools Browser Chrome dt3
>   2732 - test-windows7-32-vm/debug-web-platform-tests-1 wpt1
>   2712 - test-windows7-32-vm/debug-web-platform-tests-e10s-1 wpt1
>   2711 - test-windows7-32-vm/debug-web-platform-tests-12 wpt12
>   2696 - Mochitest e10s DevTools Browser Chrome dt4
>   2675 - Mochitest e10s DevTools Browser Chrome dt1
>   2667 - W3C Web Platform Tests e10s 10
>   2659 - test-windows7-32-vm/debug-web-platform-tests-e10s-12 wpt12
>   2589 - Mochitest e10s DevTools Browser Chrome dt7
>   2564 - Mochitest DevTools Browser Chrome dt8
>   2564 - test-windows7-32-vm/debug-mochitest-devtools-chrome-8 dt8
>   2557 - Mochitest e10s DevTools Browser Chrome dt8
>   2532 - W3C Web Platform Tests 10
>   2528 - test-windows7-32-vm/debug-mochitest-devtools-chrome-7 dt7
>   2528 - Mochitest DevTools Browser Chrome dt7
>   2527 - test-windows7-32-vm/debug-web-platform-tests-e10s-8 wpt8
>   2448 - test-windows7-32-vm/debug-web-platform-tests-8 wpt8
>   2336 - test-windows7-32-vm/debug-web-platform-tests-4 wpt4
>   2309 - test-windows7-32-vm/debug-web-platform-tests-e10s-4 wpt4
>   2272 - Mochitest 1
>   2267 - test-windows7-32-vm/debug-mochitest-1 1
>   2042 - test-windows7-32-vm/debug-mochitest-3 3
>   2042 - Mochitest 3
>   2014 - test-windows7-32-vm/debug-mochitest-5 5
>   2013 - Mochitest 5
>   1678 - Mochitest e10s DevTools Browser Chrome dt6
>   1463 - Mochitest e10s 1
>   1459 - test-windows7-32-vm/debug-mochitest-e10s-1 1
>   1424 - Mochitest 2
>   1423 - test-windows7-32-vm/debug-mochitest-2 2
>   1290 - Mochitest e10s 3
>   1289 - test-windows7-32-vm/debug-mochitest-e10s-3 3
>   1213 - test-windows7-32-vm/debug-mochitest-e10s-2 2
>   1207 - Mochitest e10s 2
>   1179 - Mochitest 4
>   1178 - test-windows7-32-vm/debug-mochitest-4 4
>   1011 - test-windows7-32-vm/debug-mochitest-e10s-4 4
>   1011 - Mochitest e10s 4
>    962 - W3C Web Platform Reftests e10s Wr-e10s
>    925 - test-windows7-32-vm/debug-web-platform-tests-reftests Wr
>    875 - W3C Web Platform Reftests Wr
>    734 - Reftest R1
>    734 - Reftest Unaccelerated Ru1
>    714 - Mochitest WebGL gl1
>    697 - Mochitest WebGL gl2
>    693 - Mochitest WebGL gl3
>    643 - Crashtest C
>    642 - test-windows7-32-vm/debug-crashtest C
>    551 - Reftest GPU e10s Rg
>    529 - Reftest Unaccelerated e10s Ru1
>    529 - Reftest e10s R-e10s1
>    504 - JSReftest J1
>    493 - Crashtest e10s C
>    404 - Mochitest Media mda
>    374 - Mochitest a11y a11y
>    374 - test-windows7-32-vm/debug-mochitest-a11y a11y
>    245 - Reftest R2
>    245 - Reftest Unaccelerated Ru2
>    211 - test-windows7-32-vm/debug-mochitest-media-2 mda2
>    175 - test-windows7-32-vm/debug-mochitest-media-1 mda1
>    173 - Mochitest e10s GPU gpu
>    164 - Mochitest GPU gpu
>    144 - test-windows7-32-vm/debug-mochitest-media-3 mda3
>    109 - test-windows7-32-vm/debug-mochitest-media-e10s-3 mda3
>     68 - Mochitest e10s WebGL gl3
>     60 - test-windows7-32-vm/debug-mochitest-media-e10s-2 mda2
>     53 - test-windows7-32-vm/debug-mochitest-media-e10s-1 mda1
>     49 - Reftest Unaccelerated e10s Ru2
>     41 - JSReftest J2
>     34 - Mochitest e10s WebGL gl1
>     22 - JSReftest e10s J1
>     22 - JSReftest e10s J2
>     17 - Mochitest e10s WebGL gl2

It shows up in 28734 tests. A few of the most prevalent:

>  11329 -        Shutdown
>  10778 - [e10s] Shutdown
>   3066 -        jetpack-package/addon-sdk/source/test/test-simple-prefs.js.testUnloadOfDynamicPrefGeneration
>    834 - [e10s] browser/components/sessionstore/test/browser_354894_perwindowpb.js
>    815 - [e10s] toolkit/mozapps/extensions/test/browser/browser_discovery.js
>    743 - [e10s] toolkit/mozapps/extensions/test/browser/browser_bug562797.js
>    626 -        browser/components/sessionstore/test/browser_354894_perwindowpb.js
>    542 - [e10s] browser/components/sessionstore/test/browser_newtab_userTypedValue.js
>    491 - [e10s] browser/components/preferences/in-content-old/tests/browser_cookies_exceptions.js
>    490 - [e10s] browser/components/preferences/in-content/tests/browser_cookies_exceptions.js

[1] https://hg.mozilla.org/mozilla-central/annotate/cac374fb0de1/caps/BasePrincipal.cpp#l380
Summary: 166,200 instances of "'NS_FAILED(rv)'" emitted from caps/BasePrincipal.cpp during linux64 debug testing → 637,100 instances of "'NS_FAILED(rv)'" emitted from caps/BasePrincipal.cpp during linux64 and win32 debug testing
Attached patch warning.patchSplinter Review
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8859017 - Flags: review?(bobbyholley)
Attachment #8859017 - Flags: review?(bobbyholley) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/58c4711b8ca2
No warning message when the creation of the principal origin fails, r=bholley
https://hg.mozilla.org/mozilla-central/rev/58c4711b8ca2
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.