nss_ckmdSessionObject_GetAttribute should return NSSCKFWItem

RESOLVED FIXED in 3.4.1

Status

NSS
Libraries
P1
normal
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Julien Pierre)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

16 years ago
This is unfinished work of bug 134095 and was reported by Nelson.

The compiler warns when compiling lib/ckfw/sessobj.c:

cc -o SunOS5.8_64_DBG.OBJ/sessobj.o -c -g -KPIC -DSVR4 -DSYSV -D__svr4
-D__svr4__ -DSOLARIS -D_REENTRANT -DSOLARIS2_8 -D_SVID_GETTOD -xarch=v9 -xs
-DXP_UNIX -DDEBUG -UNDEBUG -DDEBUG_svbld -I/usr/dt/include
-I/usr/openwin/include -I../../../../dist/SunOS5.8_64_DBG.OBJ/include
-I../../../../dist/public/security -I../../../../dist/private/security
-I../../../../dist/public/security -I../../../../dist/public/nspr  sessobj.c

"sessobj.c", line 305: warning: assignment type mismatch:

This is because after the fix for bug 134095,
nss_ckmdSessionObject_GetAttribute should return NSSCKFWItem
as opposed to const NSSItem *.
(Assignee)

Comment 1

16 years ago
Fixed on the tip in 
Repository revision: 1.9     /cvsroot/mozilla/security/nss/lib/ckfw/sessobj.c,v
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

16 years ago
I added back the 'static' qualifier on the forward declaration
that was accidentally deleted.

Checking in sessobj.c;
/cvsroot/mozilla/security/nss/lib/ckfw/sessobj.c,v  <--  sessobj.c
new revision: 1.10; previous revision: 1.9
done
Priority: -- → P1
(Reporter)

Comment 3

16 years ago
I merged the fix on the NSS_3_4_BRANCH.
Target Milestone: --- → 3.4.1
You need to log in before you can comment on or make changes to this bug.