Last Comment Bug 135721 - nss_ckmdSessionObject_GetAttribute should return NSSCKFWItem
: nss_ckmdSessionObject_GetAttribute should return NSSCKFWItem
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.4
: All All
P1 normal (vote)
: 3.4.1
Assigned To: Julien Pierre
: Sonja Mirtitsch
Depends on:
  Show dependency treegraph
Reported: 2002-04-05 09:45 PST by Wan-Teh Chang
Modified: 2002-04-09 14:39 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---


Description User image Wan-Teh Chang 2002-04-05 09:45:40 PST
This is unfinished work of bug 134095 and was reported by Nelson.

The compiler warns when compiling lib/ckfw/sessobj.c:

cc -o SunOS5.8_64_DBG.OBJ/sessobj.o -c -g -KPIC -DSVR4 -DSYSV -D__svr4
-DXP_UNIX -DDEBUG -UNDEBUG -DDEBUG_svbld -I/usr/dt/include
-I/usr/openwin/include -I../../../../dist/SunOS5.8_64_DBG.OBJ/include
-I../../../../dist/public/security -I../../../../dist/private/security
-I../../../../dist/public/security -I../../../../dist/public/nspr  sessobj.c

"sessobj.c", line 305: warning: assignment type mismatch:

This is because after the fix for bug 134095,
nss_ckmdSessionObject_GetAttribute should return NSSCKFWItem
as opposed to const NSSItem *.
Comment 1 User image Julien Pierre 2002-04-05 11:35:36 PST
Fixed on the tip in 
Repository revision: 1.9     /cvsroot/mozilla/security/nss/lib/ckfw/sessobj.c,v
Comment 2 User image Wan-Teh Chang 2002-04-05 11:45:43 PST
I added back the 'static' qualifier on the forward declaration
that was accidentally deleted.

Checking in sessobj.c;
/cvsroot/mozilla/security/nss/lib/ckfw/sessobj.c,v  <--  sessobj.c
new revision: 1.10; previous revision: 1.9
Comment 3 User image Wan-Teh Chang 2002-04-09 14:39:35 PDT
I merged the fix on the NSS_3_4_BRANCH.

Note You need to log in before you can comment on or make changes to this bug.