1357238 - Apostrophes in commit messages can break try parsing

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Brian Stack [:bstack]]

https://dxr.mozilla.org/mozilla-central/rev/c697e756f738ce37abc56f31bfbc48f55625d617/taskcluster/taskgraph/try_option_syntax.py#203 will die with a "ValueError: No closing quotation" exception for commit messages like 

Bug 1353653 - Increase spammy log's log level. try: -b do -p all -u mochitests -t none --setenv MOZ_LOG=UrlClassifierDbService:4,UrlClassifierStreamUpdater:5


Currently, this does not fail because moz-tc cleans up the message before we submit it https://github.com/taskcluster/mozilla-taskcluster/blob/1dbdeeb990595be75131b90d60866226000345ad/src/jobs/taskcluster_graph.js#L65

We should probably either make it so that in-tree stuff handles this sort of message correctly, or don't try to parse it at all and assume that moz-tc will do it for us as it does currently.

tl;dr As it stands, find_try_idx should always find an index of 0 currently. We can either get rid of this processing or make moz-tc stop pre-processing and handle this situation correctly.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I'm in favor of doing less in moz-tc :)

Comment 2

[Brian Stack [:bstack]]

Attachment: Bug 1357238 - Allow apostrophes in try commit messages

This copies the behavior of mozilla-taskcluster when it
submits try pushes. This will allow us to eventually stop
using mozilla-taskcluster.

Review commit: https://reviewboard.mozilla.org/r/145052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145052/

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8873661 [details]
Bug 1357238 - Allow apostrophes in try commit messages

https://reviewboard.mozilla.org/r/145052/#review149396

molto bene!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a17f14f2a35a
Allow apostrophes in try commit messages r=dustin

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a17f14f2a35a