Last Comment Bug 135728 - Fixes for three benign compiler warnings
: Fixes for three benign compiler warnings
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.4
: All All
P2 normal (vote)
: 3.4.1
Assigned To: Wan-Teh Chang
: Sonja Mirtitsch
Depends on:
  Show dependency treegraph
Reported: 2002-04-05 10:27 PST by Wan-Teh Chang
Modified: 2002-04-09 14:30 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Proposed patch (1.26 KB, patch)
2002-04-05 10:29 PST, Wan-Teh Chang
bugz: review+
Details | Diff | Splinter Review

Description User image Wan-Teh Chang 2002-04-05 10:27:37 PST
In stanpcertdb.c, a function declared as returning SECStatus
returns PR_FAILURE.  Since SECFailure and PR_FAILURE both
are enumeration constants with the same value (-1), this is
not a problem.

In pk11pars.c, the functions STAN_AddModuleToDefaultTrustDomain
and STAN_RemoveModuleFromDefaultTrustDomain are not declared.
Since these two functions return SECStatus (an enumeration type),
I believe it is not a problem for the compiler to implicitly
declare them as returning int.

I will attach a patch.
Comment 1 User image Wan-Teh Chang 2002-04-05 10:29:06 PST
Created attachment 77866 [details] [diff] [review]
Proposed patch
Comment 2 User image Ian McGreer 2002-04-05 10:56:11 PST
Comment on attachment 77866 [details] [diff] [review]
Proposed patch

looks good to me.
Comment 3 User image Wan-Teh Chang 2002-04-05 11:38:27 PST
Fix checked into the tip.  Thanks for the code review, Ian.
Comment 4 User image Wan-Teh Chang 2002-04-09 14:30:19 PDT
Fix has been merged on the NSS_3_4_BRANCH, just to be safe.

Note You need to log in before you can comment on or make changes to this bug.