In stanpcertdb.c, a function declared as returning SECStatus
returns PR_FAILURE. Since SECFailure and PR_FAILURE both
are enumeration constants with the same value (-1), this is
not a problem.
In pk11pars.c, the functions STAN_AddModuleToDefaultTrustDomain
and STAN_RemoveModuleFromDefaultTrustDomain are not declared.
Since these two functions return SECStatus (an enumeration type),
I believe it is not a problem for the compiler to implicitly
declare them as returning int.
I will attach a patch.
Created attachment 77866 [details] [diff] [review]
Comment on attachment 77866 [details] [diff] [review]
looks good to me.
Fix checked into the tip. Thanks for the code review, Ian.
Fix has been merged on the NSS_3_4_BRANCH, just to be safe.