The default bug view has changed. See this FAQ.

Fixes for three benign compiler warnings

RESOLVED FIXED in 3.4.1

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
In stanpcertdb.c, a function declared as returning SECStatus
returns PR_FAILURE.  Since SECFailure and PR_FAILURE both
are enumeration constants with the same value (-1), this is
not a problem.

In pk11pars.c, the functions STAN_AddModuleToDefaultTrustDomain
and STAN_RemoveModuleFromDefaultTrustDomain are not declared.
Since these two functions return SECStatus (an enumeration type),
I believe it is not a problem for the compiler to implicitly
declare them as returning int.

I will attach a patch.
(Assignee)

Comment 1

15 years ago
Created attachment 77866 [details] [diff] [review]
Proposed patch

Comment 2

15 years ago
Comment on attachment 77866 [details] [diff] [review]
Proposed patch

looks good to me.
Attachment #77866 - Flags: review+
(Assignee)

Comment 3

15 years ago
Fix checked into the tip.  Thanks for the code review, Ian.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Priority: -- → P2
Resolution: --- → FIXED
(Assignee)

Comment 4

15 years ago
Fix has been merged on the NSS_3_4_BRANCH, just to be safe.
Target Milestone: --- → 3.4.1
You need to log in before you can comment on or make changes to this bug.