Lock down devtools-core package

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Netmonitor
P1
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: rickychien, Assigned: rickychien)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---
Bug Flags:
qe-verify ?

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [netmonitor])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
devtools-core has bumped latest packages. It's time to lock down netmonitor's packages to get stable launchpad.

https://github.com/devtools-html/devtools-core/tree/6273bdbfc37f521b574ff1f275098a0b2885fe61
Comment hidden (mozreview-request)

Updated

9 months ago
Iteration: --- → 55.4 - May 1
Flags: qe-verify?
Priority: -- → P1
Comment hidden (mozreview-request)

Comment 3

9 months ago
mozreview-review
Comment on attachment 8859233 [details]
Bug 1357447 - Lock down devtools-core package

https://reviewboard.mozilla.org/r/131256/#review134138

fix the nits then we are good to go :+1:


& remember to remove the [devtools-splitter] link under `Develop with related modules` section in README.md

::: devtools/client/netmonitor/package.json:13
(Diff revision 2)
>    "dependencies": {
>      "codemirror": "^5.24.2",
> -    "devtools-config": "^0.0.12",
> -    "devtools-launchpad": "^0.0.65",
> -    "devtools-modules": "^0.0.23",
> -    "devtools-source-editor": "^0.0.2",
> +    "devtools-config": "=0.0.12",
> +    "devtools-launchpad": "=0.0.67",
> +    "devtools-modules": "=0.0.24",
> +    "devtools-source-editor": "^0.0.3",

=0.0.3
Attachment #8859233 - Flags: review?(gasolin)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

9 months ago
mozreview-review
Comment on attachment 8859233 [details]
Bug 1357447 - Lock down devtools-core package

https://reviewboard.mozilla.org/r/131256/#review134172

::: devtools/client/netmonitor/package.json:13
(Diff revision 4)
>    "dependencies": {
>      "codemirror": "^5.24.2",
> -    "devtools-config": "^0.0.12",
> -    "devtools-launchpad": "^0.0.65",
> -    "devtools-modules": "^0.0.23",
> -    "devtools-source-editor": "^0.0.2",
> +    "devtools-config": "=0.0.12",
> +    "devtools-launchpad": "=0.0.67",
> +    "devtools-modules": "=0.0.24",
> +    "devtools-source-editor": "=0.0.3",

since we did not depends on devtools-splitter module anymore,

remember to remove the [devtools-splitter] link under `Develop with related modules` section in README.md
Attachment #8859233 - Flags: review?(gasolin)
Comment hidden (mozreview-request)
(Assignee)

Comment 8

9 months ago
mozreview-review-reply
Comment on attachment 8859233 [details]
Bug 1357447 - Lock down devtools-core package

https://reviewboard.mozilla.org/r/131256/#review134172

> since we did not depends on devtools-splitter module anymore,
> 
> remember to remove the [devtools-splitter] link under `Develop with related modules` section in README.md

Good catch!

Comment 9

9 months ago
mozreview-review
Comment on attachment 8859233 [details]
Bug 1357447 - Lock down devtools-core package

https://reviewboard.mozilla.org/r/131256/#review134210
Attachment #8859233 - Flags: review?(gasolin) → review+

Comment 10

9 months ago
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c60d5721705
Lock down devtools-core package r=gasolin

Comment 11

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8c60d5721705
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.