Closed
Bug 1357476
Opened 7 years ago
Closed 6 years ago
Replace django-rest-swagger with djangorestframework's native interactive docs
Categories
(Tree Management :: Treeherder: API, defect, P1)
Tree Management
Treeherder: API
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(2 files)
d-r-f 3.6 added a new native docs feature: http://www.django-rest-framework.org/topics/3.6-announcement/ http://www.django-rest-framework.org/topics/documenting-your-api/ This needs setting up (adding to urls.py etc) however may be sufficient to replace Django rest swagger entirely.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → emorley
Assignee | ||
Updated•7 years ago
|
Assignee: emorley → nobody
Assignee | ||
Updated•7 years ago
|
Component: Treeherder → Treeherder: API
Assignee | ||
Comment 2•6 years ago
|
||
It turns out this reduces the time taken to run `collectstatic` by 70% (due to the reduction in staticfiles and how long Brotli compression takes), which will help with our deploy times.
Comment 3•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8951119 -
Flags: review?(cdawson)
Updated•6 years ago
|
Attachment #8951119 -
Flags: review?(cdawson) → review+
Comment 4•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/0aec43a139888e86e44cc11e4e667f19c28881ad Bug 1357476 - Replace django-rest-swagger with native d-r-f docs (#3230) Now that django-rest-framework supports interactive docs natively, we no longer need to use the additional django-rest-swagger package: http://www.django-rest-framework.org/topics/3.6-announcement/#interactive-api-documentation http://www.django-rest-framework.org/topics/documenting-your-api/ This significantly reduces the number of static files that have to be processed, reducing the time taken for `collectstatic` (which is run on every deployment and takes a while due to Brotli compression) by 70%.
Assignee | ||
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 5•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8964701 -
Flags: review?(cdawson)
Updated•6 years ago
|
Attachment #8964701 -
Flags: review?(cdawson) → review+
Comment 6•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/3d50e32d4da798029dab06ddceb3bc75f2d4920e Bug 1357476 - Remove django-rest-swagger remnants (#3390) These are leftover from 0aec43a (#3230).
You need to log in
before you can comment on or make changes to this bug.
Description
•