1357541 - Stop pretending PipelineId::mHandle is a uint64_t layers id

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

Various bits of code ([1], [2], etc.) seem to use the PipelineId::mHandle field as a layers id. This is wrong, because the mHandle is only the bottom 32-bit half of the layers id. The layers id is a 64-bit field. We should either make the mHandle a 64-bit field, or we should use AsUint64 [3] to get the full 64-bit value.

[1] http://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/gfx/layers/ipc/CompositorBridgeParent.cpp#1604
[2] http://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/gfx/layers/ipc/CrossProcessCompositorBridgeParent.cpp#193
[3] http://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/gfx/webrender_bindings/WebRenderTypes.h#108

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1357541 - Use the full 64 bit value of the PipelineId when converting to a layers ID.

Review commit: https://reviewboard.mozilla.org/r/131384/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131384/

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 8859345 [details]
Bug 1357541 - Use the full 64 bit value of the PipelineId when converting to a layers ID.

https://reviewboard.mozilla.org/r/131384/#review134262

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=b502c4aa3f3d498c92c01f19de31b9d96123c30d is green

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/a7152802939c
Use the full 64 bit value of the PipelineId when converting to a layers ID. r=nical

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/a7152802939c