Closed
Bug 1357541
Opened 8 years ago
Closed 8 years ago
Stop pretending PipelineId::mHandle is a uint64_t layers id
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
Various bits of code ([1], [2], etc.) seem to use the PipelineId::mHandle field as a layers id. This is wrong, because the mHandle is only the bottom 32-bit half of the layers id. The layers id is a 64-bit field. We should either make the mHandle a 64-bit field, or we should use AsUint64 [3] to get the full 64-bit value.
[1] http://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/gfx/layers/ipc/CompositorBridgeParent.cpp#1604
[2] http://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/gfx/layers/ipc/CrossProcessCompositorBridgeParent.cpp#193
[3] http://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/gfx/webrender_bindings/WebRenderTypes.h#108
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8859345 [details]
Bug 1357541 - Use the full 64 bit value of the PipelineId when converting to a layers ID.
https://reviewboard.mozilla.org/r/131384/#review134262
Attachment #8859345 -
Flags: review?(nical.bugzilla) → review+
|
Assignee | |
Comment 3•8 years ago
|
||
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/a7152802939c
Use the full 64 bit value of the PipelineId when converting to a layers ID. r=nical
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•8 years ago
|
||
status-firefox55:
--- → fixed
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•