Stop pretending PipelineId::mHandle is a uint64_t layers id

RESOLVED FIXED in Firefox 55

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

Other Branch
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

Various bits of code ([1], [2], etc.) seem to use the PipelineId::mHandle field as a layers id. This is wrong, because the mHandle is only the bottom 32-bit half of the layers id. The layers id is a 64-bit field. We should either make the mHandle a 64-bit field, or we should use AsUint64 [3] to get the full 64-bit value.

[1] http://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/gfx/layers/ipc/CompositorBridgeParent.cpp#1604
[2] http://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/gfx/layers/ipc/CrossProcessCompositorBridgeParent.cpp#193
[3] http://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/gfx/webrender_bindings/WebRenderTypes.h#108
Blocks: 1345054
Comment on attachment 8859345 [details]
Bug 1357541 - Use the full 64 bit value of the PipelineId when converting to a layers ID.

https://reviewboard.mozilla.org/r/131384/#review134262
Attachment #8859345 - Flags: review?(nical.bugzilla) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/a7152802939c
Use the full 64 bit value of the PipelineId when converting to a layers ID. r=nical
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.