Remove unused includes

RESOLVED FIXED in Firefox 55

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
Created attachment 8859348 [details] [diff] [review]
Remove unused includes

There are left over from when we built display lists on the parent side.
(Assignee)

Comment 1

10 months ago
Comment on attachment 8859348 [details] [diff] [review]
Remove unused includes

>commit ad520859b0d9c5ab132da0219beaf0083f265e8b
>Author: Jeff Muizelaar <jmuizelaar@mozilla.com>
>Date:   Wed Apr 12 18:35:53 2017 -0400
>
>    Remove unused includes
>
>diff --git a/gfx/layers/ipc/PWebRenderBridge.ipdl b/gfx/layers/ipc/PWebRenderBridge.ipdl
>index 9f894d6..766041f 100644
>--- a/gfx/layers/ipc/PWebRenderBridge.ipdl
>+++ b/gfx/layers/ipc/PWebRenderBridge.ipdl
>@@ -13,16 +13,17 @@ include "mozilla/layers/WebRenderMessageUtils.h";
> include WebRenderMessages;
> include protocol PCompositorBridge;
> include protocol PTexture;
> 
> using struct mozilla::layers::TextureInfo from "mozilla/layers/CompositorTypes.h";
> using mozilla::layers::CompositableHandle from "mozilla/layers/LayersTypes.h";
> using mozilla::wr::ByteBuffer from "mozilla/webrender/WebRenderTypes.h";
> using mozilla::wr::ImageKey from "mozilla/webrender/WebRenderTypes.h";
>+using mozilla::wr::FontKey from "mozilla/webrender/WebRenderTypes.h";
> using WrBuiltDisplayListDescriptor from "mozilla/webrender/webrender_ffi.h";
> using WrAuxiliaryListsDescriptor from "mozilla/webrender/webrender_ffi.h";
> 
> namespace mozilla {
> namespace layers {
> 
> sync protocol PWebRenderBridge
> {
>diff --git a/gfx/layers/ipc/WebRenderMessages.ipdlh b/gfx/layers/ipc/WebRenderMessages.ipdlh
>index 3604722..152c9ff 100644
>--- a/gfx/layers/ipc/WebRenderMessages.ipdlh
>+++ b/gfx/layers/ipc/WebRenderMessages.ipdlh
>@@ -4,35 +4,17 @@
> /* This Source Code Form is subject to the terms of the Mozilla Public
>  * License, v. 2.0. If a copy of the MPL was not distributed with this
>  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> 
> include LayersSurfaces;
> include LayersMessages;
> include protocol PTexture;
> 
>-using WrBorderRadius from "mozilla/webrender/webrender_ffi.h";
>-using WrBorderSide from "mozilla/webrender/webrender_ffi.h";
>-using WrColor from "mozilla/webrender/webrender_ffi.h";
>-using WrSize from "mozilla/webrender/webrender_ffi.h";
>-using WrRect from "mozilla/webrender/webrender_ffi.h";
>-using WrPoint from "mozilla/webrender/webrender_ffi.h";
>-using WrGradientStop from "mozilla/webrender/webrender_ffi.h";
>-using WrGradientExtendMode from "mozilla/webrender/webrender_ffi.h";
>-using WrGlyphArray from "mozilla/webrender/webrender_ffi.h";
>-using WrMixBlendMode from "mozilla/webrender/webrender_ffi.h";
>-using WrBoxShadowClipMode from "mozilla/webrender/webrender_ffi.h";
>-using MaybeImageMask from "mozilla/webrender/WebRenderTypes.h";
>-using mozilla::gfx::Matrix4x4 from "mozilla/gfx/Matrix.h";
>-using mozilla::wr::ByteBuffer from "mozilla/webrender/WebRenderTypes.h";
>-using mozilla::wr::PipelineId from "mozilla/webrender/WebRenderTypes.h";
>-using mozilla::wr::ImageRendering from "mozilla/webrender/WebRenderTypes.h";
> using mozilla::wr::ImageKey from "mozilla/webrender/WebRenderTypes.h";
>-using mozilla::wr::FontKey from "mozilla/webrender/WebRenderTypes.h";
>-using mozilla::LayerIntRegion from "Units.h";
> 
> namespace mozilla {
> namespace layers {
> 
> struct OpAddExternalImage {
>   uint64_t externalImageId;
>   ImageKey key;
> };
Attachment #8859348 - Attachment is patch: true
(Assignee)

Updated

10 months ago
Attachment #8859348 - Flags: review?(bugmail)
Assignee: nobody → jmuizelaar
Attachment #8859348 - Flags: review?(bugmail) → review+

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d728885b337f
https://hg.mozilla.org/mozilla-central/rev/727663c9f23a
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Please land WR-related changes on graphics in the future, this is causing merge conflicts :(
You need to log in before you can comment on or make changes to this bug.