1357555 - A migrated favicon has expiration = 0, unexpected by the previous code

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P1)

Description

[Marco Bonardo [:mak]]

Migrated favicons have expiration = 0, since they should be replaced asap.
Unfortunatley this case didn't exist before, so the code handling expiration in SetAndFetchFaviconForPage doesn't handle it correctly.
This means a migrated favicon is always valid and never replaced.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1357555 - Properly handle an expiration value of 0 when fetching an icon.

Favicons migrated from the old store have expiration set to 0.
The code is not expecting that, since expiration has always been positive, thus
those icons are always considered valid and never replaced. They should instead be
considered expired.

Review commit: https://reviewboard.mozilla.org/r/131500/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131500/

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 8859469 [details]
Bug 1357555 - Properly handle an expiration value of 0 when fetching an icon.

https://reviewboard.mozilla.org/r/131500/#review134536

LGTM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3507329c5999
Properly handle an expiration value of 0 when fetching an icon. r=adw

Comment 4

[Iris Hsiao [:ihsiao]]

sorry had to back this out for eslint failure like https://treeherder.mozilla.org/logviewer.html#?job_id=92928428&repo=autoland&lineNumber=4734

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8859469 [details]
Bug 1357555 - Properly handle an expiration value of 0 when fetching an icon.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131500/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6bbb991c0d2
Properly handle an expiration value of 0 when fetching an icon. r=adw

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a6bbb991c0d2