Closed Bug 1357555 Opened 4 years ago Closed 4 years ago
A migrated favicon has expiration = 0, unexpected by the previous code
59 bytes, text/x-review-board-request
Migrated favicons have expiration = 0, since they should be replaced asap. Unfortunatley this case didn't exist before, so the code handling expiration in SetAndFetchFaviconForPage doesn't handle it correctly. This means a migrated favicon is always valid and never replaced.
Comment on attachment 8859469 [details] Bug 1357555 - Properly handle an expiration value of 0 when fetching an icon. https://reviewboard.mozilla.org/r/131500/#review134536 LGTM
Attachment #8859469 - Flags: review?(adw) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/3507329c5999 Properly handle an expiration value of 0 when fetching an icon. r=adw
sorry had to back this out for eslint failure like https://treeherder.mozilla.org/logviewer.html#?job_id=92928428&repo=autoland&lineNumber=4734
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/a6bbb991c0d2 Properly handle an expiration value of 0 when fetching an icon. r=adw
You need to log in before you can comment on or make changes to this bug.