Note: There are a few cases of duplicates in user autocompletion which are being worked on.

A migrated favicon has expiration = 0, unexpected by the previous code

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Places
P1
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: mak, Assigned: mak)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [fxsearch])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
Migrated favicons have expiration = 0, since they should be replaced asap.
Unfortunatley this case didn't exist before, so the code handling expiration in SetAndFetchFaviconForPage doesn't handle it correctly.
This means a migrated favicon is always valid and never replaced.
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Whiteboard: [fxsearch]

Comment 2

3 months ago
mozreview-review
Comment on attachment 8859469 [details]
Bug 1357555 - Properly handle an expiration value of 0 when fetching an icon.

https://reviewboard.mozilla.org/r/131500/#review134536

LGTM
Attachment #8859469 - Flags: review?(adw) → review+

Comment 3

3 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/3507329c5999
Properly handle an expiration value of 0 when fetching an icon. r=adw

Comment 4

3 months ago
sorry had to back this out for eslint failure like https://treeherder.mozilla.org/logviewer.html#?job_id=92928428&repo=autoland&lineNumber=4734
Comment hidden (mozreview-request)

Comment 6

3 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/a6bbb991c0d2
Properly handle an expiration value of 0 when fetching an icon. r=adw

Comment 7

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a6bbb991c0d2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.