Closed Bug 1357555 Opened 3 years ago Closed 3 years ago

A migrated favicon has expiration = 0, unexpected by the previous code

Categories

(Toolkit :: Places, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Migrated favicons have expiration = 0, since they should be replaced asap.
Unfortunatley this case didn't exist before, so the code handling expiration in SetAndFetchFaviconForPage doesn't handle it correctly.
This means a migrated favicon is always valid and never replaced.
Whiteboard: [fxsearch]
Comment on attachment 8859469 [details]
Bug 1357555 - Properly handle an expiration value of 0 when fetching an icon.

https://reviewboard.mozilla.org/r/131500/#review134536

LGTM
Attachment #8859469 - Flags: review?(adw) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/3507329c5999
Properly handle an expiration value of 0 when fetching an icon. r=adw
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/a6bbb991c0d2
Properly handle an expiration value of 0 when fetching an icon. r=adw
https://hg.mozilla.org/mozilla-central/rev/a6bbb991c0d2
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.