The UE spec says that we are only going to show the animated alert for the first account which has new mail. Due to a race condition, if you have several accounts with the same biff interval, your alert would have text for both accounts and they would be merged together on one big line. We need to just show the text for the first account. Patch is trivial.
Created attachment 77881 [details] [diff] [review] Only show the text for the first account with new mail
*** Bug 134416 has been marked as a duplicate of this bug. ***
Discussed in Mail News bug mtg with Engineering QA and PjM. Decided to ADT2 and plus this bug.
I think instead of finalText here + if (animatedAlertText.IsEmpty()) // if we haven't filled in the animated alert text yet + animatedAlertText = finalText; it should be animatedAlertText = toolTipText right ? otherwise we are going to skip all that truncation logic
actually I WANT to skip all of that truncation logic. The code you are looking at builds the tooltip text for the biff icon in the system tray. Windows limits you to 128 characters in that tooltip. So there's lots of code in there for only listing as many accounts as will fit in 128 characters for the tooltip. This bug fix is for the animated alert text and has nothing to do with the tooltip nor does it have the 128 character limitation. I just want the text from the first account and not the tooltip text which has multiple accounts. Hope that helps clarify.
Comment on attachment 77881 [details] [diff] [review] Only show the text for the first account with new mail thanks for the clarification, r=naving
Comment on attachment 77881 [details] [diff] [review] Only show the text for the first account with new mail sr=bienvenu
This has been checked into the. Leaving open until I get it into the moz 1.0 branch.
*** Bug 137299 has been marked as a duplicate of this bug. ***
keyword pixie dust to put on the adt1.0.0 radar
adt1.0.0+ (on ADT's behalf) for checkin into the 1.0 branch. Pls check this in to the branch today. After it is checked in, pls add fixed1.0.0. Once QA has verified it on the branch, then add verified1.0.0.
This should be marked fixed since it is fixed on the trunk. Once QA has had a chance to look at it I'll petition drivers for the branch.
Windows 2000, Windows NT 4.0, Windows 98, Windows XP... I've verified *on the trunk* that if you have multiple new messages on multiple accounts, we only display the 'username has x new messages' hyperlink for the first account that has mail. The other account, if it also has mail, has the information in the tooltip, along with the first account. Thanks to Gary for verification on Windows NT 4.0. Verified with trunk build 2002-04-16-03.
Comment on attachment 77881 [details] [diff] [review] Only show the text for the first account with new mail a=asa (on behalf of drivers) for checkin to the 1.0 branch
fixed on the 1.0 branch
Tested this on: Branch 1.0.0 commercial build 2002-04-20-06 using: Windows XP, Windows 2000, Windows 98, and Windows NT 4.0 With multiple accounts receiving new mail, we only show them in the system tray notification icon's tooltip. The alert itself only contains the 1st account which has mail. Verified FIXED on the branch and trunk, so replacing fixed1.0.0 keyword with verified1.0.0