Closed Bug 1357581 Opened 4 years ago Closed 4 years ago

[geckoview] GeckoView example app crashes when brought back to foreground

Categories

(Core Graveyard :: Embedding: APIs, defect)

Product:
Core Graveyard
Component:
Embedding: APIs
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: esawin, Assigned: esawin)

Details

Attachments

(1 file)

0001-Bug-1357581-1.0-Don-t-override-URL-when-restoring-an.patch
1.59 KB, patch
snorp
: review+
Details | Diff | Splinter Review 
STR:
1. Open GeckoView example app.
2. Press Android home button to background the app.
3. Open the example app again.
Removed the debug log which caused the crash and also changed onNewIntent to not override the URL with the default URL.
Attachment #8859376 - Flags: review?(snorp)
Comment on attachment 8859376 [details] [diff] [review]
0001-Bug-1357581-1.0-Don-t-override-URL-when-restoring-an.patch

Review of attachment 8859376 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops...
Attachment #8859376 - Flags: review?(snorp) → review+
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70debe6d9f95
[1.0] Don't override URL when restoring and avoid accessing uninitialized intent data. r=snorp
https://hg.mozilla.org/mozilla-central/rev/70debe6d9f95
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.