Closed
Bug 1357593
Opened 7 years ago
Closed 7 years ago
spidermonkey tests fail on other 64-bit architectures
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: jbicha, Assigned: ptomato)
References
Details
Attachments
(1 file)
2.69 KB,
patch
|
sfink
:
review+
lizzard
:
approval-mozilla-esr52+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20170321232041 Steps to reproduce: I package GNOME for Ubuntu. GNOME is currently using mozjs38 (but they will be switching to mozjs52 in a few months). As part of the build, I run the jstests. 3 tests fail on arm64, ppc64el and s390x (all 64-bit architectures). All 3 tests are skipped on amd64 because apparently the tests time out there (or at least did 7 years ago). js1_5/Regress/regress-422348.js js1_5/Array/regress-157652.js js1_5/Array/regress-330812.js Unfortunately, I don't have direct access to this hardware, but I can do test builds using Ubuntu PPAs. Yes, I could skip these tests in the Ubuntu package, but I'd like to get these test working properly in Firefox itself instead of just distro-patching it. Actual results: FAILED! [reported from test()] Proper overflow error reporting : Expected value 'InternalError: allocation size overflow', Actual value 'out of memory' TEST-UNEXPECTED-FAIL | js1_5/Regress/regress-422348.js | (args: "") Full build logs are at https://launchpad.net/ubuntu/+source/mozjs38/38.2.1~rc0-0ubuntu6 Click the architecture then click buildlog. Expected results: Could we allow 'out of memory' as a valid return value?
Reporter | ||
Comment 1•7 years ago
|
||
The tests are basically the same in the current trunk. (Yes, I know mozjs38 is no longer supported.)
Reporter | ||
Updated•7 years ago
|
Component: General → JavaScript Engine
OS: Unspecified → Linux
Product: Testing → Core
Hardware: Unspecified → ARM
Assignee | ||
Comment 2•7 years ago
|
||
FWIW, here's the patch that Fedora uses to disable those tests.
Updated•7 years ago
|
Attachment #8884709 -
Flags: review+
Updated•7 years ago
|
Assignee: nobody → philip.chimento
Updated•7 years ago
|
Attachment #8884709 -
Flags: checkin?
Updated•7 years ago
|
Attachment #8884709 -
Flags: checkin?
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d1cd7515c3f8 Skip JS tests on all 64-bit archs. r=sfink
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d1cd7515c3f8
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8884709 [details] [diff] [review] tests: Skip on all 64-bit archs.patch [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: It's good for Spidermonkey embedders to be able to run the Spidermonkey test suite without modifying it. User impact if declined: None Fix Landed on Version: 57 Risk to taking this patch (and alternatives if risky): No risk, just disables three regression tests on certain architectures where they time out anyway. String or UUID changes made by this patch: None See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #8884709 -
Flags: approval-mozilla-esr52?
Comment 6•7 years ago
|
||
Comment on attachment 8884709 [details] [diff] [review] tests: Skip on all 64-bit archs.patch Just skips some tests, OK to uplift for esr52
Attachment #8884709 -
Flags: approval-mozilla-esr52? → approval-mozilla-esr52+
Updated•7 years ago
|
status-firefox-esr52:
--- → affected
tracking-firefox-esr52:
--- → 57+
Comment 7•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr52/rev/f4c683a4e95f
You need to log in
before you can comment on or make changes to this bug.
Description
•