[infer] Ignore httpurlclient errors

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ahunt, Assigned: ahunt)

Tracking

Trunk
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
We want to remove httpclientlib ( mobile/android/thirdparty/ch/boye/httpclientandroidlib ) as it is deprecated, uses up lots of space, and eats into our method count. There's little value in seeing or fixing these issues if we're going to move to something more modern, so let's just ignore any infer issues it produces, in order to let us focus on the actual core app issues.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8859440 [details]
Bug 1357629 - Add httpclientandroidlib to .inferconfig ignore list

https://reviewboard.mozilla.org/r/131480/#review134394

Consider whether you want to make this m/a/thirdparty, since we're unlikely to ever address thirdparty issues.
Attachment #8859440 - Flags: review?(nalexander) → review+

Comment 3

2 years ago
mozreview-review
Comment on attachment 8859440 [details]
Bug 1357629 - Add httpclientandroidlib to .inferconfig ignore list

https://reviewboard.mozilla.org/r/131480/#review134420
Attachment #8859440 - Flags: review?(npark) → review+
Assignee

Comment 4

2 years ago
mozreview-review-reply
Comment on attachment 8859440 [details]
Bug 1357629 - Add httpclientandroidlib to .inferconfig ignore list

https://reviewboard.mozilla.org/r/131480/#review134394

I did consider it - but it seemed better to me to at least be aware of issues in newly introduced libraries. It's easy to widen the set of excluded libraries if/when we add  new libraries, but we can make the decision per-library. (Hopefully we won't need to add third-party code all that often, but if we do I'm guessing we'll also be in charge of maintaining it, so fixing issues there would generally be worthwhile.)

Comment 5

2 years ago
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a1023c9c098
Add httpclientandroidlib to .inferconfig ignore list r=nalexander,njpark

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4a1023c9c098
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.