1357630 - [infer] Fix appEventDispatcher NULL_DEREFERENCE in GeckoApp

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Andrzej Hunt :ahunt]

getEventDispatcher()/getApEventDispatcher cause 28 infer NULL_DEREFERENCE errors. We can squash them with one simple fix.

Comment 1

[Andrzej Hunt :ahunt]

Attachment: Bug 1357630 - infer: (NULL_DEREFERENCE) add null-check to getAppEventDispatcher

Every single caller of getAppEventDispatcher() and getEventDispatcher()
assumes a non-null return value, so let's make sure we're actually returning
a non-null value. This commit doesn't effectively change runtime behaviour
(any previously NPE crashes will now result in a crash due to IllegalStateException),
however we now at least have an obvious error message in that situation.

In reality, no code should run before onCreate(), so this should realistically
never happen - but we should still check to ensure that is the case.

(This removes 28 infer NULL_DEREFERENCE warnings.)

Review commit: https://reviewboard.mozilla.org/r/131462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131462/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8859429 [details]
Bug 1357630 - infer: (NULL_DEREFERENCE) add null-check to getAppEventDispatcher

https://reviewboard.mozilla.org/r/131462/#review134148

OK, I can see a huge number of consumers that expect a non-null return, so rock on.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab3beca99070
infer: (NULL_DEREFERENCE) add null-check to getAppEventDispatcher r=nalexander

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab3beca99070