Closed Bug 1357642 Opened 2 years ago Closed 2 years ago

Investigate "WARNING: 'mIsInEditAction', file c:/mozilla/src/editor/libeditor/EditorBase.cpp, line 1896"

Categories

(Core :: Editor, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox55 --- wontfix
firefox56 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

Details

(Keywords: inputmethod)

Attachments

(1 file)

When you use IME on debug build, you see a lot of warnings about mIsInEditAction.

> WARNING: 'mIsInEditAction', file c:/mozilla/src/editor/libeditor/EditorBase.cpp, line 1896

This is not a new regression, though, we should investigate this. (could be improve debug build's test performance.)
Priority: -- → P3
Comment on attachment 8878958 [details]
Bug 1357642 TextEditor::UpdateIMEComposition() shouldn't call NotifyEditorObservers(eNotifyEditorObserversOfBefore) by itself

https://reviewboard.mozilla.org/r/149820/#review154822
Attachment #8878958 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/89d2cb80a186
TextEditor::UpdateIMEComposition() shouldn't call NotifyEditorObservers(eNotifyEditorObserversOfBefore) by itself r=m_kato
https://hg.mozilla.org/mozilla-central/rev/89d2cb80a186
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
setting 55 status to wontfix based on the "not a new regression" description in comment 0.
(In reply to Julien Cristau [:jcristau] from comment #6)
> setting 55 status to wontfix based on the "not a new regression" description
> in comment 0.

Yeah, this only affects the performance of automated tests on Windows. So, it's not worthwhile to uplift it.
You need to log in before you can comment on or make changes to this bug.