Investigate "WARNING: 'mIsInEditAction', file c:/mozilla/src/editor/libeditor/EditorBase.cpp, line 1896"

RESOLVED FIXED in Firefox 56

Status

()

Core
Editor
P3
normal
RESOLVED FIXED
7 months ago
5 months ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod})

Trunk
mozilla56
inputmethod
Points:
---

Firefox Tracking Flags

(firefox55 wontfix, firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

When you use IME on debug build, you see a lot of warnings about mIsInEditAction.

> WARNING: 'mIsInEditAction', file c:/mozilla/src/editor/libeditor/EditorBase.cpp, line 1896

This is not a new regression, though, we should investigate this. (could be improve debug build's test performance.)

Updated

7 months ago
Priority: -- → P3
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c04a3428dd235250d06b4c96aac112ef97a24ac
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 3

5 months ago
mozreview-review
Comment on attachment 8878958 [details]
Bug 1357642 TextEditor::UpdateIMEComposition() shouldn't call NotifyEditorObservers(eNotifyEditorObserversOfBefore) by itself

https://reviewboard.mozilla.org/r/149820/#review154822
Attachment #8878958 - Flags: review?(m_kato) → review+

Comment 4

5 months ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/89d2cb80a186
TextEditor::UpdateIMEComposition() shouldn't call NotifyEditorObservers(eNotifyEditorObserversOfBefore) by itself r=m_kato

Comment 5

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/89d2cb80a186
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
setting 55 status to wontfix based on the "not a new regression" description in comment 0.
status-firefox55: affected → wontfix
(In reply to Julien Cristau [:jcristau] from comment #6)
> setting 55 status to wontfix based on the "not a new regression" description
> in comment 0.

Yeah, this only affects the performance of automated tests on Windows. So, it's not worthwhile to uplift it.
You need to log in before you can comment on or make changes to this bug.