Closed Bug 1357644 Opened 7 years ago Closed 7 years ago

Use wr::ExternalImageId instead of uint64_t for external image id

Categories

(Core :: Graphics: WebRender, enhancement)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 2 obsolete files)

patch - Use wr::ExternalImageId instead of uint64_t for external image id
49.59 KB, patch
nical
: review+
Details | Diff | Splinter Review 
Use wr::ExternalImageId instead of uint64_t with Bug 1356944 Comment 5.
Blocks: 1356944
Assignee: nobody → sotaro.ikeda.g
Depends on: 1357392
Summary: Use wr::ExternalImageId instead of uint64_t → Use wr::ExternalImageId instead of uint64_t for external image id
Attachment #8859446 - Flags: review?(nical.bugzilla)

        Attachment #8859446 -
        Attachment is obsolete: true

        Attachment #8859446 -
        Flags: review?(nical.bugzilla)

    
  

        Attachment #8859446 -
        Attachment is obsolete: false

    
  

        Attachment #8859477 -
        Attachment is obsolete: true

    
  

        Attachment #8859446 -
        Flags: review?(nical.bugzilla)

    
    

    
  
Comment on attachment 8859446 [details] [diff] [review]
patch - Use wr::ExternalImageId instead of uint64_t for external image id

Review of attachment 8859446 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks a lot!

::: gfx/webrender_bindings/webrender_ffi_generated.h
@@ +50,5 @@
>    A8 = 1,
>    RGB8 = 2,
>    RGBA8 = 3,
>    RGBAF32 = 4,
> +  RG8 = 5,

I suppose cbindgen made this change for whatever reason.

        Attachment #8859446 -
        Flags: review?(nical.bugzilla) → review+

    
    

    
  
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/765939ca757d
Use wr::ExternalImageId instead of uint64_t for external image id r=nical
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: