Don't expire all relations for expired icons when updating icons for a specific page

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Places
P1
normal
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: mak, Assigned: mak)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [fxsearch])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a month ago
There's a problem in the association query, when we update icons for a page, we should remove all the relations for the expired icons associated to that page. The problem is that we instead remove all the relations for the expired icons for any page.
This means that if I have 2 bookmarks to bugzilla entries and I visit one, both relations are expired, but only one is restored to the new icon.
Comment hidden (mozreview-request)

Comment 2

a month ago
mozreview-review
Comment on attachment 8859481 [details]
Bug 1357664 - Don't delete all relations to expired icons when updating icons for a specific page.

https://reviewboard.mozilla.org/r/131504/#review134610

LGTM
Attachment #8859481 - Flags: review?(adw) → review+

Comment 3

a month ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/ad7d2ae91ce6
Don't delete all relations to expired icons when updating icons for a specific page. r=adw
https://hg.mozilla.org/mozilla-central/rev/ad7d2ae91ce6
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.