Closed
Bug 1357671
Opened 8 years ago
Closed 8 years ago
stylo: animation_type should be None for css logical properties
Categories
(Core :: CSS Parsing and Computation, enhancement, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: boris, Assigned: boris)
References
Details
Attachments
(2 files)
In the block [1], we should also add animation_type = None to override the animation_type for those properties with logical=true. Therefore, using %if animation_type = "normal" won't include logical properties.
[1] http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/servo/components/style/properties/data.py#178-180
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8859486 -
Flags: review?(emilio+bugs)
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8859486 [details]
Bug 1357671 - Make animation_type of logical properties be None.
https://reviewboard.mozilla.org/r/131508/#review134258
Oh, nice catch :)
Attachment #8859486 -
Flags: review?(emilio+bugs) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
I will leave a comment there because logical properties will be animatable soon or later (Bug 1309752). For now, it is still non-animatable in stylo.
|
|
Assignee | |
Comment 4•8 years ago
|
||
|
|
Assignee | |
Comment 5•8 years ago
|
||
Landed into Servo
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•