1357681 - Create a document for mask-image only if the url of mask source contains element id

Status: RESOLVED INVALID

(Core :: Layout, enhancement)

Description

[u459114]

We currently always create a document for mask-image with url value. It's a waste if there is no element id in url, since that kind of resource can be used as image only, not svg-mask.

Comment 1

[u459114]

We can check whether maskUri has a reference at [1], if it doesn't, no bother to create a svg document in nsReferencedElement::Reset

[1]
https://hg.mozilla.org/mozilla-central/file/39a3c3fbfabd/layout/svg/nsSVGEffects.cpp#l398

Comment 2

[u459114]

Attachment: Bug 1357681 - Do not trigger svg document parsing if the URL of mask-image does not contain reference.

Review commit: https://reviewboard.mozilla.org/r/131522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131522/

Comment 3

[u459114]

Comment on attachment 8859518 [details]
Bug 1357681 - Do not trigger svg document parsing if the URL of mask-image does not contain reference.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131522/diff/1-2/

Comment 4

[u459114]

Comment on attachment 8859518 [details]
Bug 1357681 - Do not trigger svg document parsing if the URL of mask-image does not contain reference.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131522/diff/2-3/

Comment 5

[u459114]

Comment on attachment 8859518 [details]
Bug 1357681 - Do not trigger svg document parsing if the URL of mask-image does not contain reference.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131522/diff/3-4/

Comment 6

[u459114]

We had prevent this kind of download at
http://searchfox.org/mozilla-central/source/dom/base/nsReferencedElement.cpp#41