Remove the remaining gonk code from application update

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Application Update
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Most of the app update gonk code has already been removed in other bugs.
Created attachment 8859513 [details] [diff] [review]
patch rev1

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b70d49c995f389e69ff5938a087e25a23e297921
Created attachment 8859536 [details] [diff] [review]
Patch rev1

Try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf905ca5359b92a47c91a7282c3cf35f034bd544
Attachment #8859513 - Attachment is obsolete: true
Comment on attachment 8859536 [details] [diff] [review]
Patch rev1

>diff --git a/toolkit/mozapps/update/UpdateTelemetry.jsm b/toolkit/mozapps/update/UpdateTelemetry.jsm
>--- a/toolkit/mozapps/update/UpdateTelemetry.jsm
>+++ b/toolkit/mozapps/update/UpdateTelemetry.jsm
>@@ -169,17 +169,16 @@ this.AUSTLMY = {
>    */
>   DWNLD_SUCCESS: 0,
>   DWNLD_RETRY_OFFLINE: 1,
>   DWNLD_RETRY_NET_TIMEOUT: 2,
>   DWNLD_RETRY_CONNECTION_REFUSED: 3,
>   DWNLD_RETRY_NET_RESET: 4,
>   DWNLD_ERR_NO_UPDATE: 5,
>   DWNLD_ERR_NO_UPDATE_PATCH: 6,
>-  DWNLD_ERR_NO_PATCH_FILE: 7,
Note: This was added for gonk in bug 785124 and prior to that there was no check. I also verified that this has never been reported in telemetry.
Attachment #8859536 - Attachment description: Patch in progress → Patch rev1
Attachment #8859536 - Flags: review?(mhowell)
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #3)
> Comment on attachment 8859536 [details] [diff] [review]
> Patch rev1
> 
> >diff --git a/toolkit/mozapps/update/UpdateTelemetry.jsm b/toolkit/mozapps/update/UpdateTelemetry.jsm
> >--- a/toolkit/mozapps/update/UpdateTelemetry.jsm
> >+++ b/toolkit/mozapps/update/UpdateTelemetry.jsm
> >@@ -169,17 +169,16 @@ this.AUSTLMY = {
> >    */
> >   DWNLD_SUCCESS: 0,
> >   DWNLD_RETRY_OFFLINE: 1,
> >   DWNLD_RETRY_NET_TIMEOUT: 2,
> >   DWNLD_RETRY_CONNECTION_REFUSED: 3,
> >   DWNLD_RETRY_NET_RESET: 4,
> >   DWNLD_ERR_NO_UPDATE: 5,
> >   DWNLD_ERR_NO_UPDATE_PATCH: 6,
> >-  DWNLD_ERR_NO_PATCH_FILE: 7,
> Note: This was added for gonk in bug 785124 and prior to that there was no
> check. I also verified that this has never been reported in telemetry.
Sorry, the "if (!patchFile) {" was added in that bug and this telemetry was added later inside that block. That block which was added in bug 785124 has been removed and hence the telemetry value has been as well.
Comment on attachment 8859536 [details] [diff] [review]
Patch rev1

Review of attachment 8859536 [details] [diff] [review]:
-----------------------------------------------------------------

This is my favorite kind of patch to review. ;)
Attachment #8859536 - Flags: review?(mhowell) → review+

Comment 6

7 months ago
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31e942586dd8
Remove the remaining gonk code from application update. r=mhowell

Comment 7

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/31e942586dd8
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.