1357685 - Remove the remaining gonk code from application update

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement)

Description

[Robert Strong (they/them - no direct email)]

Most of the app update gonk code has already been removed in other bugs.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b70d49c995f389e69ff5938a087e25a23e297921

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: Patch rev1

Try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf905ca5359b92a47c91a7282c3cf35f034bd544

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 8859536 [details] [diff] [review]
Patch rev1

>diff --git a/toolkit/mozapps/update/UpdateTelemetry.jsm b/toolkit/mozapps/update/UpdateTelemetry.jsm
>--- a/toolkit/mozapps/update/UpdateTelemetry.jsm
>+++ b/toolkit/mozapps/update/UpdateTelemetry.jsm
>@@ -169,17 +169,16 @@ this.AUSTLMY = {
>    */
>   DWNLD_SUCCESS: 0,
>   DWNLD_RETRY_OFFLINE: 1,
>   DWNLD_RETRY_NET_TIMEOUT: 2,
>   DWNLD_RETRY_CONNECTION_REFUSED: 3,
>   DWNLD_RETRY_NET_RESET: 4,
>   DWNLD_ERR_NO_UPDATE: 5,
>   DWNLD_ERR_NO_UPDATE_PATCH: 6,
>-  DWNLD_ERR_NO_PATCH_FILE: 7,
Note: This was added for gonk in bug 785124 and prior to that there was no check. I also verified that this has never been reported in telemetry.

Comment 4

[Robert Strong (they/them - no direct email)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #3)
> Comment on attachment 8859536 [details] [diff] [review]
> Patch rev1
> 
> >diff --git a/toolkit/mozapps/update/UpdateTelemetry.jsm b/toolkit/mozapps/update/UpdateTelemetry.jsm
> >--- a/toolkit/mozapps/update/UpdateTelemetry.jsm
> >+++ b/toolkit/mozapps/update/UpdateTelemetry.jsm
> >@@ -169,17 +169,16 @@ this.AUSTLMY = {
> >    */
> >   DWNLD_SUCCESS: 0,
> >   DWNLD_RETRY_OFFLINE: 1,
> >   DWNLD_RETRY_NET_TIMEOUT: 2,
> >   DWNLD_RETRY_CONNECTION_REFUSED: 3,
> >   DWNLD_RETRY_NET_RESET: 4,
> >   DWNLD_ERR_NO_UPDATE: 5,
> >   DWNLD_ERR_NO_UPDATE_PATCH: 6,
> >-  DWNLD_ERR_NO_PATCH_FILE: 7,
> Note: This was added for gonk in bug 785124 and prior to that there was no
> check. I also verified that this has never been reported in telemetry.
Sorry, the "if (!patchFile) {" was added in that bug and this telemetry was added later inside that block. That block which was added in bug 785124 has been removed and hence the telemetry value has been as well.

Comment 5

[Molly Howell (she/her) (no longer active)]

Comment on attachment 8859536 [details] [diff] [review]
Patch rev1

Review of attachment 8859536 [details] [diff] [review]:
-----------------------------------------------------------------

This is my favorite kind of patch to review. ;)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31e942586dd8
Remove the remaining gonk code from application update. r=mhowell

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/31e942586dd8