Closed Bug 1357702 Opened 4 years ago Closed 4 years ago

Running ESLint on windows fails in js/src/builtin and js/src/shell due to unexpected characters

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

3 Branch
enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Panos reported to me that we're getting failures on Windows when running all ESLint on everything. I tracked this down to a path issue in the eslint-plugin-spidermonkey-js package.

c:\src\gecko\js\src\builtin\Array.js
  911:1  error  Parsing error: Unexpected character '#'  (eslint)

c:\src\gecko\js\src\builtin\RegExp.js
  556:1  error  Parsing error: Unexpected character '#'  (eslint)

c:\src\gecko\js\src\builtin\RegExpGlobalReplaceOpt.h.js
  22:1  error  Parsing error: Unexpected character '#'  (eslint)

c:\src\gecko\js\src\builtin\RegExpLocalReplaceOpt.h.js
  19:1  error  Parsing error: Unexpected character '#'  (eslint)

c:\src\gecko\js\src\builtin\String.js
  753:1  error  Parsing error: Unexpected character '#'  (eslint)

c:\src\gecko\js\src\builtin\TypedArray.js
  1272:1  error  Parsing error: Unexpected character '#'  (eslint)

c:\src\gecko\js\src\builtin\TypedObject.js
  1:1  error  Parsing error: Unexpected character '#'  (eslint)

c:\src\gecko\js\src\builtin\Utilities.js
  25:1  error  Parsing error: Unexpected character '#'  (eslint)

c:\src\gecko\js\src\shell\ModuleLoader.js
  38:1  error  Parsing error: Unexpected character '#'  (eslint)
Comment on attachment 8859538 [details]
Bug 1357702 - Make eslint-plugin-spidermonkey-js handle paths correct on Windows to avoid Unexpected character issues on ESLint.

https://reviewboard.mozilla.org/r/131542/#review134508
Attachment #8859538 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/368a60db302d
Make eslint-plugin-spidermonkey-js handle paths correct on Windows to avoid Unexpected character issues on ESLint. r=mossop
https://hg.mozilla.org/mozilla-central/rev/368a60db302d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.