1357705 - (stylo-inidomutils) [meta] Stylo: Investigate inIDOMUtils APIs used by DevTools

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P5)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

DevTools currently uses[1] the following APIs from inIDOMUtils[2], some of which may need Stylo specific support:

Already updated for Stylo:

* getCSSStyleRules (bug 1346256)
* getAllStyleSheet (bug 1322661)

Appears to use Gecko style objects, probably needs updating for Stylo:

* parseStyleSheet
* selectorMatchesElement

Appears to use shared style objects, but Stylo passes invalid data:

* getRuleLine (line is always set to 0)
* getRuleColumn (column is always set to 0)
* getRelativeRuleLine (line is always set to 0)

Appears to only query static style data, could be deferred:

* getCSSPseudoElementNames
* isValidCSSColor
* getCSSPropertyNames
* getCSSValuesForProperty
* getSubpropertiesForCSSProperty
* isInheritedProperty
* cssPropertyIsShorthand
* cssPropertySupportsType
* cssPropertyIsValid
* getCSSLexer

Appears to poke element state, seems correctly forwarded to Stylo:

* hasPseudoClassLock
* addPseudoClassLock
* removePseudoClassLock
* clearPseudoClassLocks

Seems unrelated to Stylo:

* getUsedFontFaces

[1]: http://searchfox.org/mozilla-central/search?q=%5CbDOMUtils%5Cb&case=true&regexp=true&path=devtools
[2]: http://searchfox.org/mozilla-central/source/layout/inspector/inIDOMUtils.idl

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Clearing priority for now, so it appears on :bholley's triage, but probably P2?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Looks like I missed a few originally.

Appears to use Gecko style objects, probably needs updating for Stylo:

* getSelectorCount
* getSelectorText
* getSpecificity

Seems unrelated to Stylo:

* colorToRGBA

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It seems like we've covered the APIs we need here, great work all! \o/