Intermittent test_ext_webrequest_upload.html | Test left extra windows or tabs: {"extraWindows":[],"extraTabs":["file_WebRequest_page3.html?trigger=form&upload=

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
WebExtensions: General
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: Treeherder Bug Filer, Assigned: mixedpuppy)

Tracking

({intermittent-failure})

unspecified
mozilla55
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [stockwell fixed])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

7 months ago
treeherder
Filed by: cbook [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=92642551&repo=mozilla-central

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-win32-debug/1492595781/mozilla-central_win7_vm-debug_test-mochitest-e10s-5-bm139-tests1-windows-build48.txt.gz

Comment 1

7 months ago
27 failures in 817 pushes (0.033 failures/push) were associated with this bug in the last 7 days. 

This is the #38 most frequent failure this week.  

Repository breakdown:
* autoland: 13
* mozilla-inbound: 6
* mozilla-central: 6
* try: 2

Platform breakdown:
* windows7-32-vm: 12
* osx-10-10: 11
* windows8-64: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1357723&startday=2017-04-17&endday=2017-04-23&tree=all
I did some retriggers on m-c:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=win%20vm%20debug%20mochitest-e10s-5&tochange=c0ea5ed7f91a6be996a4a3c5ab25e2cdf6b4377e&fromchange=2b6a66a98e253ba158f3960f1c68ad49b2ebcdb4

looked like changes from m-i, so I retriggered there:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=win%20vm%20debug%20mochitest-e10s-5&fromchange=e0a577db4b13e16ce693c50abfc960133220bdf8&tochange=edda32a96d465ad3f2ee03f031a202f3c4910676&selectedJob=93725166

but the m-i stuff doesn't show this problem, I assume this is an interaction with something from autoland+m-i :(

I would rather look at the test itself at this point than hunting for a root cause.

It appears that we have an extra tab sitting around, screenshots indicate this is still loading/connecting and the content looks blank.  

I don't see recent changes to this test file- this is primarily failing on debug configs!

:andym, could you find someone to look at this in the next week or two?
Flags: needinfo?(amckay)
Whiteboard: [stockwell needswork]
(Assignee)

Comment 3

7 months ago
I'm taking a guess that fixing intermittent failures for bug 1326298 caused this since I changed a test file being used by this intermittent.
Comment hidden (mozreview-request)
(Assignee)

Comment 5

7 months ago
The patch in reviewboard forces a couple tests to wait for the tabs to close properly.  try runs are initiated.
Assignee: nobody → mixedpuppy
Flags: needinfo?(amckay)

Comment 6

7 months ago
17 failures in 141 pushes (0.121 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 7
* autoland: 5
* try: 4
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 9
* windows7-32-vm: 7
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1357723&startday=2017-04-24&endday=2017-04-24&tree=all

Updated

7 months ago
Summary: Intermittent test_ext_webrequest_upload.html | Test left extra windows or tabs: {"extraWindows":[],"extraTabs":["http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/test-oop-extensions/file_WebRequest_page3.html?trigger=form&upload= → Intermittent test_ext_webrequest_upload.html | Test left extra windows or tabs: {"extraWindows":[],"extraTabs":["file_WebRequest_page3.html?trigger=form&upload=
thanks :mixedpuppy for getting a patch for this!
Duplicate of this bug: 1357914

Comment 9

7 months ago
65 failures in 883 pushes (0.074 failures/push) were associated with this bug in the last 7 days. 

This is the #9 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 28
* mozilla-inbound: 27
* try: 4
* mozilla-central: 4
* graphics: 2

Platform breakdown:
* osx-10-10: 30
* windows7-32-vm: 26
* windows8-64: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1357723&startday=2017-04-24&endday=2017-04-30&tree=all
(Assignee)

Updated

7 months ago
Attachment #8861176 - Flags: review?(mwein)

Comment 10

7 months ago
mozreview-review
Comment on attachment 8861176 [details]
Bug 1357723 fix intermittent failure of tab close,

https://reviewboard.mozilla.org/r/133136/#review138188

In general I think this looks good and I'm happy to give r+.

I don't know if yielding on the "tab-closed" message will ensure the window has finished closing though. If not, you might be able to use `BrowserTestUtils.windowClosed` (http://searchfox.org/mozilla-central/source/testing/mochitest/BrowserTestUtils/BrowserTestUtils.jsm#559).

::: toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html:235
(Diff revision 1)
>    addScript("file_script_nonexistent.js");
>    yield extension.awaitMessage("done");
>  });
>  
>  add_task(function* test_webRequest_tabId() {
> +  function background() {

This test looks very similar to the one which follows it, so I think it would be good to have them share some code if possible.
Attachment #8861176 - Flags: review?(mwein) → review+

Comment 11

7 months ago
15 failures in 146 pushes (0.103 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 7
* mozilla-inbound: 5
* graphics: 3

Platform breakdown:
* windows7-32-vm: 7
* osx-10-10: 6
* windows8-64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1357723&startday=2017-05-02&endday=2017-05-02&tree=all
Comment on attachment 8861176 [details]
Bug 1357723 fix intermittent failure of tab close,

https://reviewboard.mozilla.org/r/133136/#review138740
Attachment #8861176 - Flags: review?(kmaglione+bmo) → review+
(Assignee)

Comment 13

7 months ago
(In reply to (on PTO until May 8) Matthew Wein [:mattw] from comment #10)

> I don't know if yielding on the "tab-closed" message will ensure the window
> has finished closing though. If not, you might be able to use
> `BrowserTestUtils.windowClosed`
> (http://searchfox.org/mozilla-central/source/testing/mochitest/
> BrowserTestUtils/BrowserTestUtils.jsm#559).

BrowserTestUtils isn't available in our mochitest tests, otherwise that'd be preferable.

Comment 14

7 months ago
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fe781f252ec4
fix intermittent failure of tab close, r=kmag,mattw

Comment 15

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fe781f252ec4
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Comment 16

7 months ago
27 failures in 770 pushes (0.035 failures/push) were associated with this bug in the last 7 days. 

This is the #40 most frequent failure this week.  

Repository breakdown:
* autoland: 13
* mozilla-inbound: 7
* graphics: 5
* mozilla-central: 2

Platform breakdown:
* windows7-32-vm: 13
* osx-10-10: 11
* windows8-64: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1357723&startday=2017-05-01&endday=2017-05-07&tree=all
Whiteboard: [stockwell needswork] → [stockwell fixed]
You need to log in before you can comment on or make changes to this bug.