135775 - embedding should default to packaging up native theme support

Status: RESOLVED INVALID

(Core Graveyard :: Embedding: APIs, defect)

Description

[TVL]

[ this really belongs in embedding: packaging or embedding: general ]

since the classic them in mozilla now allows mac & windows to run with the os
native 'theme'/look, it would seems that embedding should be able to and should
default to this.  that way anyone can take mozilla and embed it into their app
with it looking "native" like the does.

Comment 1

[TVL]

topembed per jud past mail.

Comment 2

[Mike Pinkerton (not reading bugmail)]

i thought we already picked up the classic skin in the jar manifest, which is
using moz-appearance/themes to draw widgetry.

however, the only place you'll see this today is scrollbars. xbl form controls
are off and are not slated to be 'on' until post machV, and even then, they need
to be styled to use moz-appearance.

Comment 3

[Adam Lock]

Embedding packages the classic theme with uses moz-appearance for most widget
styles and that is what Gecko should default to using. This will automatically
cause the native renderer to be invoked if present otherwise the css & graphics
from the classic theme should be used.

We had a problem with arrow graphics not being present but that should be fixed.

Thomas, what symptoms are you seeing?

Comment 4

[TVL]

i wasn't picking it up when i first pulled 099, but that could be due to the
also busted arrow graphics.  i'll try to repull 099 and see how things go.

Comment 5

[Adam Lock]

Thomas can you confirm with the latest 0.9.9 pull?

Comment 6

[Mike Pinkerton (not reading bugmail)]

i talked to hyatt, and the native theme drawing only works on WinXP. It doesn't
kick in for win2k or lower.

Comment 7

[Adam Lock]

The classic theme should render whether there is a native theme engine or not.
We had a problem with arrow graphics which was fixed so AFAIK this bug is WFM
but I'm waiting on the confirmation.

Comment 8

[TVL]

i think pink hit the problem in my case, i'm on 2k and didn't realize the
theming only worked on XP.  is there a reason why 2k wasn't supported?

Comment 9

[Garrett Arch Blythe]

theme work involved new common control v6 APIs (UxTheme.lib), available only in XP.

Comment 10

[Adam Lock]

W2K doesn't have a native theme engine so the classic theme falls back on its
bundled graphics and styles to render arrows, scrollbars, radiobuttons etc.

Marking INVALID.