1357781 - Custom Tab: Edit Site Settings option not implemented

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Huawei Honor (Android 5.1.1);
Build: Nightly 55.0a1 (2017-04-18);

Steps to reproduce:
1. Open https://goo.gl/zhWYkv from Gmail;
2. When the doorhanger is displayed with: "m.aliexpress.com contains plugin content. Would you like to activate it?" Tap on Activate;
3. Tap on green lock from toolbar.

Expected result:
A message is displayed with information about site and with option "Edit Site settings" witch clears the settings made for that site.

Actual result:
No "Edit Site settings" option is displayed to clear the settings made.

Notes:
Also reproducible with https://goo.gl/HjLqwC.

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[triage]
P1

Comment 2

[Julian Chu [:walkingice]]

Attachment: Bug 1357781 - ActionProvider be able to use new context

The Context menu will use ActionProvider to create ActionView to use.
GeckoActionProvider cache a Context inside.

In CustomTabs, we might change Theme at runtime, therefore cached
context might be outdated. Now we check wheter the context is the same
one.

Review commit: https://reviewboard.mozilla.org/r/140420/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140420/

Comment 3

[Julian Chu [:walkingice]]

Attachment: Bug 1357781 - Popup menu has its own theme

Both of Popup menu and Context menu will use MenuItemDefault.

However in CustomTabs, Popup menu only has one style, regardless light
or dark theme. Now we create one specific theme for it. Wish one day we
can get rid of this.

Review commit: https://reviewboard.mozilla.org/r/140422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140422/

Comment 4

[Julian Chu [:walkingice]]

Attachment: Bug 1357781 - To tint state drawawble in MenuItem

The drawable mState in MenuItemDefault is to present state image for
MORE(">"), CHECKED or UNCHECKED.

In CustomTabs there might be dark theme. So we need to tint this
drawable by text-color.

Review commit: https://reviewboard.mozilla.org/r/140424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140424/

Comment 5

[Julian Chu [:walkingice]]

Set wrong bug nubmer on patch, so clear previous review request :-/

Comment 6

[Julian Chu [:walkingice]]

Attachment: Bug 1357781 - Enable function of edit site settings in SiteIdentity

The SiteIdentityPopup has a clickable-text to show a dialog to edit
permission for the browsring-site. Its visibility is decided by message
from EventDispatcher("Permission:CheckResult").

Now register listener by visibility of ActionBar.(or Activity, actually).

Review commit: https://reviewboard.mozilla.org/r/140578/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140578/

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8868928 [details]
Bug 1357781 - Enable function of edit site settings in SiteIdentity

https://reviewboard.mozilla.org/r/140578/#review144886

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45eb05278a0f
Enable function of edit site settings in SiteIdentity r=sebastian

Comment 9

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/45eb05278a0f

Comment 10

[Sorina Florean [:sflorean]]

Verified as fixed in build (55.0a1/2017.05.28):
Device: Asus ZenPad 8 (Android 6.0.1).