1357798 - Sync ping errors should not include URL strings

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P1)

Description

[Thom Chiovoloni [:tcsc] (ex-moco)]

Currently we include the string error message, looking at some of the errors in the telemetry for bookmarks, there are instances of http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/dom/bindings/Errors.msg#53 (e.g. "http://foo*.com is not a valid url" or similar) present.

This makes sense -- AFAICT there are a lot of places this might be generated in sync's code, e.g. anywhere where a URL might be parsed, normalized, etc, but is probably not acceptable to include in our telemetry, as it's somewhat personally identifiable.

It's also more noise than I think we want, even if there were no PII concern.

Comment 1

[Lina Butler [:lina]]

This also makes error analysis difficult, since the error strings would appear to be unique.

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1357798 - Ensure URLs don't end up in sync error telemetry.

Review commit: https://reviewboard.mozilla.org/r/148128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148128/

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8876796 [details]
Bug 1357798 - Ensure URLs don't end up in sync error telemetry.

https://reviewboard.mozilla.org/r/148128/#review152638

Comment 4

[Mozilla Autoland]

hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try
searching for changes
remote: waiting for lock on working directory of /repo/hg/mozilla/try held by process '22914' on host 'hgssh4.dmz.scl3.mozilla.com'
remote: abort: working directory of /repo/hg/mozilla/try: timed out waiting for lock held by hgssh4.dmz.scl3.mozilla.com:22914
abort: stream ended unexpectedly (got 0 bytes, expected 4)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3514a4240c2
Ensure URLs don't end up in sync error telemetry. r=markh

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e3514a4240c2